Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Catch fatal errors when syntax highlighting - #68326
Conversation
For some errors the lexer will unwind so we need to handle that in addition to handling `token::Unknown`.
GuillaumeGomez
commented
Jan 18, 2020
The "simpler" solution in here I arrived to was to simply update the pulldown-cmark version. However we're still waiting for the new release since that when I updated to the current one, I discovered some bugs. What do you think? If you still prefer to go on with this PR, please at least add a TODO or equivalent in the code and open an issue so we can remove this catch. |
ollie27
commented
Jan 19, 2020
I think you're thinking of a different issue. The syntax highlighting has nothing to do with pulldown-cmark. The unwinding here is coming from rustc's lexer and according to #63288 it's intentional, at least for now. |
GuillaumeGomez
commented
Jan 19, 2020
My bad! Then looks all good to me, thanks! @bors: r+ |
bors
commented
Jan 19, 2020
📌 Commit 79061d0 has been approved by |
…rors, r=GuillaumeGomez rustdoc: Catch fatal errors when syntax highlighting For some errors the lexer will unwind so we need to handle that in addition to handling `token::Unknown`. Fixesrust-lang#56885 r? @GuillaumeGomez
Rollup of 5 pull requests Successful merges: - #68326 (rustdoc: Catch fatal errors when syntax highlighting) - #68335 (Remove real_drop_in_place) - #68353 (Remove `rustc_error_codes` deps except in `rustc_driver`) - #68357 (rustdoc: Fix handling of compile errors when running `rustdoc --test`) - #68365 (Clean up error codes) Failed merges: r? @ghost
For some errors the lexer will unwind so we need to handle that in addition to handling
token::Unknown.Fixes#56885
r? @GuillaumeGomez