Skip to content

Ensure that we error when calling "const extern fn" with wrong convention - #68370

Merged
bors merged 1 commit into
rust-lang:masterfrom
Aaron1011:const-extern-test
Jan 27, 2020
Merged

Ensure that we error when calling "const extern fn" with wrong convention#68370
bors merged 1 commit into
rust-lang:masterfrom
Aaron1011:const-extern-test

Conversation

@Aaron1011

@Aaron1011Aaron1011 commented Jan 19, 2020

Copy link
Copy Markdown
Contributor

See #64926

@rust-highfive

rust-highfive commented Jan 19, 2020

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 19, 2020
@CentrilCentril added the F-const_extern_fn `#![feature(const_extern_fn)]` label Jan 20, 2020
@Centril

Centril commented Jan 20, 2020

Copy link
Copy Markdown
Contributor

r? @RalfJung

@RalfJung

RalfJung commented Jan 20, 2020

Copy link
Copy Markdown
Member

(I hope this is not urgent, I am traveling this week)

@Aaron1011

Aaron1011 commented Jan 20, 2020

Copy link
Copy Markdown
ContributorAuthor

This is just a test to ensure that the current, correct behavior doesn't change. It's not urgent at all.

RalfJung
RalfJung reviewed Jan 26, 2020
View reviewed changes
Comment threadsrc/test/ui/consts/const-extern-fn/abi-mismatch.rs Outdated
@Aaron1011

Aaron1011 commented Jan 27, 2020

Copy link
Copy Markdown
ContributorAuthor

@RalfJung: Updated

@RalfJung

RalfJung commented Jan 27, 2020

Copy link
Copy Markdown
Member

Thanks!

@bors r+ rollup=always

@bors

bors commented Jan 27, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 4a65032 has been approved by RalfJung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2020
emilyalbini added a commit to emilyalbini/rust that referenced this pull request Jan 27, 2020
@emilyalbini
Rollup merge ofrust-lang#68370- Aaron1011:const-extern-test, r=Ralf…
7e82434
…Jung
Ensure that we error when calling "const extern fn" with wrong convention
See rust-lang#64926
@emilyalbiniemilyalbini mentioned this pull request Jan 27, 2020
Merged
bors added a commit that referenced this pull request Jan 27, 2020
@bors
Auto merge of#68566- pietroalbini:rollup-22hbo3e, r=pietroalbini
8a79d08
Rollup of 4 pull requests
Successful merges:
- #67928 (Update RELEASES.md for 1.41.0)
- #68370 (Ensure that we error when calling "const extern fn" with wrong convention)
- #68531 ([self-profiler] Two small cleanups)
- #68562 (Fix spelling errors)
Failed merges:
r? @ghost
@bors
bors merged commit 4a65032 into rust-lang:masterJan 27, 2020
@Aaron1011
Aaron1011 deleted the const-extern-test branch January 27, 2020 15:50
@Aaron1011Aaron1011 mentioned this pull request Mar 16, 2020
Closed
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments

Assignees

@RalfJungRalfJung

Labels

F-const_extern_fn`#![feature(const_extern_fn)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Aaron1011@rust-highfive@Centril@RalfJung@bors@alexcrichton