Uh oh!
There was an error while loading. Please reload this page.
pprust: use as_deref - #68441
Merged
Merged
Conversation
rust-highfive
commented
Jan 22, 2020
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Jan 22, 2020
Member
@bors r+ Not entirely sure that I like the new form better, but overall I wish this wasn't necessary, and it doesn't seem too much worse :) |
bors
commented
Jan 22, 2020
Collaborator
📌 Commit 7962ccb has been approved by |
bors
commented
Jan 22, 2020
Collaborator
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Jan 22, 2020
…ulacrum pprust: use as_deref Some drive-by cleanup.
petrochenkov
commented
Jan 22, 2020
Contributor
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Jan 22, 2020
…ulacrum pprust: use as_deref Some drive-by cleanup.
tmandry added a commit
to tmandry/rust
that referenced
this pull request
Jan 23, 2020
…ulacrum pprust: use as_deref Some drive-by cleanup.
bors added a commit
that referenced
this pull request
Jan 23, 2020
Rollup of 10 pull requests Successful merges: - #67195 ([experiment] Add `-Z no-link` flag) - #68253 (add bare metal ARM Cortex-A targets to rustc) - #68361 (Unbreak linking with lld 9 on FreeBSD 13.0-CURRENT i386) - #68388 (Make `TooGeneric` error in WF checking a proper error) - #68409 (Micro-optimize OutputFilenames) - #68410 (Export weak symbols used by MemorySanitizer) - #68425 (Fix try-op diagnostic in E0277 for methods) - #68440 (bootstrap: update clippy subcmd decription) - #68441 (pprust: use as_deref) - #68462 (librustc_mir: don't allocate vectors where slices will do.) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some drive-by cleanup.