Implement proper C ABI lowering for RISC-V by msizanoen1 · Pull Request #68452 · rust-lang/rust

msizanoen1 · 2020-01-22T11:29:18Z

This is necessary for full RISC-V psABI compliance when passing argument across C FFI boundary.

rust-highfive · 2020-01-22T11:29:22Z

(rust_highfive has picked a reviewer for you, use r? to override)

lenary · 2020-01-22T11:51:14Z

Thanks for opening a pull request!

I would like to see codegen tests for each ABI (I would be content to only test the ABIs currently used by rustc), which are as comprehensive as the clang tests for the same. I'm happy to guide you to writing them, but they should be based on the tests in clang/test/CodeGen/riscv*-abi.c. This: https://github.com/llvm/llvm-project/blob/master/clang/test/CodeGen/riscv32-ilp32-abi.c for example, contains some of the tests for the ilp32 abi.

This will involve using structs annotated #[repr(C)] and functions annotated extern "C". There is guidance on adding tests in https://rust-lang.github.io/rustc-guide/tests/adding.html

msizanoen1 · 2020-01-23T05:18:29Z

The implementation is now complete. Now the only remaining part is adding tests.

msizanoen1 · 2020-01-23T12:22:52Z

@rustbot modify labels: +T-compiler

msizanoen1 · 2020-01-24T05:40:53Z

@rustbot modify labels: -S-waiting-on-author +S-waiting-on-review
It's now ready for review. No test are added because the are currently no RISC-V test runners on CI yet

programmerjake · 2020-01-24T06:52:01Z

It's now ready for review. No test are added because the are currently no RISC-V test runners on CI yet.

Seems like a good idea to add a RISC-V test runner using QEMU or similar.

lenary · 2020-02-04T09:29:11Z

@msizanoen1 there were some structs in your tests (specifically DoubleCharChar) that were thought to be "interesting" enough cases to add to the general purpose tests to ensure all backends got them correct, including RISC-V.

eddyb · 2020-02-04T16:26:16Z

r? @nagisa (see #68452 (review))

nagisa · 2020-02-04T21:21:45Z

@bors r=nagisa,eddyb

bors · 2020-02-04T21:21:48Z

📌 Commit 3963387 has been approved by nagisa,eddyb

bors · 2020-02-04T23:51:22Z

⌛ Testing commit 3963387 with merge 737fd80bb3fc446fc83d9030c01f3ad638c2bf31...

rust-highfive · 2020-02-04T23:56:29Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2020-02-04T23:56:43Z

💔 Test failed - checks-azure

msizanoen1 · 2020-02-08T09:33:34Z

@nagisa @eddyb Can you retry merge? It looks like a spurious error:

2020-02-04T23:54:10.1096957Z Updating crates.io index
2020-02-04T23:54:24.3224839Z Downloading crates ...
2020-02-04T23:54:24.5236532Z warning: spurious network error (2 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/getopts/0.2.21/download`, got 502
2020-02-04T23:54:24.5405630Z warning: spurious network error (1 tries remaining): failed to get 200 response from `https://crates.io/api/v1/crates/getopts/0.2.21/download`, got 502
2020-02-04T23:54:24.5896285Z error: failed to download from `https://crates.io/api/v1/crates/getopts/0.2.21/download`
2020-02-04T23:54:24.5897385Z 2020-02-04T23:54:24.5898138Z Caused by:
2020-02-04T23:54:24.5898568Z failed to get 200 response from `https://crates.io/api/v1/crates/getopts/0.2.21/download`, got 502

eddyb · 2020-02-08T10:54:20Z

@bors retry

@lenary

Implement proper C ABI lowering for RISC-V This is necessary for full RISC-V psABI compliance when passing argument across C FFI boundary. cc @lenary

bors · 2020-02-08T18:10:54Z

⌛ Testing commit 3963387 with merge 07a34df...

@lenary

Implement proper C ABI lowering for RISC-V This is necessary for full RISC-V psABI compliance when passing argument across C FFI boundary. cc @lenary

bors · 2020-02-08T21:27:59Z

☀️ Test successful - checks-azure
Approved by: nagisa,eddyb
Pushing 07a34df to master...

rust-highfive assigned estebank Jan 22, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 22, 2020

jonas-schievink added the O-riscv Target: RISC-V architecture label Jan 22, 2020

msizanoen1 force-pushed the riscv-abi branch 4 times, most recently from cd71c24 to 796b21dCompare January 22, 2020 13:56

This comment has been minimized.
Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2020

msizanoen1 force-pushed the riscv-abi branch 2 times, most recently from a73e032 to bac26c4Compare January 23, 2020 04:54

msizanoen1 force-pushed the riscv-abi branch 3 times, most recently from c8993cc to a7dea90Compare January 23, 2020 10:31

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 23, 2020

msizanoen1 force-pushed the riscv-abi branch from a7dea90 to 990bd0aCompare January 23, 2020 12:56

lenary mentioned this pull request Jan 23, 2020
Add riscv64gc-unknown-linux-gnu target #66661
Merged

msizanoen1 force-pushed the riscv-abi branch from 990bd0a to f7386e7Compare January 24, 2020 01:34

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 24, 2020

msizanoen1 force-pushed the riscv-abi branch from f7386e7 to c3536d2Compare January 24, 2020 05:42

msizanoen1 changed the title ~~Implement proper hard-float ABI lowering for RISC-V~~Implement proper C ABI lowering for RISC-VJan 24, 2020

msizanoen1 mentioned this pull request Jan 24, 2020
Support riscv64gc-unknown-linux-gnu target #62117
Closed

Add tests for RISC-V C ABI
3963387

msizanoen1 force-pushed the riscv-abi branch from f464c51 to 3963387Compare February 4, 2020 10:28

rust-highfive assigned nagisa and unassigned eddyb Feb 4, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 4, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2020

Dylan-DPC-zz mentioned this pull request Feb 8, 2020
Rollup of 7 pull requests #68956
Closed

bors added a commit that referenced this pull request Feb 8, 2020
Auto merge of#68452- msizanoen1:riscv-abi, r=nagisa,eddyb
07a34df
Implement proper C ABI lowering for RISC-V This is necessary for full RISC-V psABI compliance when passing argument across C FFI boundary. cc @lenary

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 8, 2020

bors merged commit 3963387 into rust-lang:masterFeb 8, 2020

msizanoen1 deleted the riscv-abi branch February 9, 2020 03:31

lenary mentioned this pull request Mar 30, 2020
Allow building for hard-float targets in RISC-V #65024
Closed

Uh oh!

Uh oh!

Conversation

msizanoen1 commented Jan 22, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jan 22, 2020

Uh oh!

lenary commented Jan 22, 2020

Uh oh!

This comment has been minimized.

msizanoen1 commented Jan 23, 2020

Uh oh!

msizanoen1 commented Jan 23, 2020

Uh oh!

msizanoen1 commented Jan 24, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

programmerjake commented Jan 24, 2020

Uh oh!

lenary commented Feb 4, 2020

Uh oh!

eddyb commented Feb 4, 2020

Uh oh!

nagisa commented Feb 4, 2020

Uh oh!

bors commented Feb 4, 2020

Uh oh!

bors commented Feb 4, 2020

Uh oh!

rust-highfive commented Feb 4, 2020

Uh oh!

bors commented Feb 4, 2020

Uh oh!

msizanoen1 commented Feb 8, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eddyb commented Feb 8, 2020

Uh oh!

bors commented Feb 8, 2020

Uh oh!

bors commented Feb 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

msizanoen1 commented Jan 22, 2020•
edited
Loading

msizanoen1 commented Jan 24, 2020•
edited
Loading

msizanoen1 commented Feb 8, 2020•
edited
Loading