Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #68506
Merged
Merged
Conversation
Partially address rust-lang#64167.
Fixesrust-lang#68368 Previously, I assumed that the substs contained only types, which caused the computed index number to be wrong.
The call to `count` on the inner iterator can overflow even if `Skip` itself would return less that `usize::max_value()` items.
This change adds the x86_64-fuchsia and aarch64-fuchsia LLVM targets to those allowed to invoke -Zsanitizer. Currently, the only overlap between compiler_rt sanitizers supported by both rustc and Fuchsia is ASan.
This was a typo that slipped in, and meant that we were still not properly clearing out std.
…y-vec, r=davidtwco Suggest borrowing `Vec<NonCopy>` in for loop Partially address rust-lang#64167.
…estebank Account for non-types in substs for opaque type error messages Fixesrust-lang#68368 Previously, I assumed that the substs contained only types, which caused the computed index number to be wrong.
Avoid overflow in `std::iter::Skip::count` The call to `count` on the inner iterator can overflow even if `Skip` itself would return less that `usize::max_value()` items. Fixesrust-lang#68139
…r=alexcrichton Enable ASan on Fuchsia This change adds the x86_64-fuchsia and aarch64-fuchsia LLVM targets to those allowed to invoke -Zsanitizer. Currently, the only overlap between compiler_rt sanitizers supported by both rustc and Fuchsia is ASan.
Implement `unused_parens` for block return values Fixesrust-lang#68386 r? @Centril
Add my (@flip1995) name to .mailmap
…ing, r=alexcrichton Clear out std, not std tools This was a typo that slipped in, and meant that we were still not properly clearing out std. This is basically rust-lang#67760 but actually correct...
tmandry
commented
Jan 24, 2020
MemberAuthor
@bors r+ p=7 rollup=never |
bors
commented
Jan 24, 2020
Collaborator
📌 Commit 7f8a61d has been approved by |
bors
commented
Jan 24, 2020
Collaborator
bors added a commit
that referenced
this pull request
Jan 24, 2020
Rollup of 7 pull requests Successful merges: - #68424 (Suggest borrowing `Vec<NonCopy>` in for loop) - #68438 (Account for non-types in substs for opaque type error messages) - #68469 (Avoid overflow in `std::iter::Skip::count`) - #68473 (Enable ASan on Fuchsia) - #68479 (Implement `unused_parens` for block return values) - #68483 (Add my (@flip1995) name to .mailmap) - #68500 (Clear out std, not std tools) Failed merges: r? @ghost
bors
commented
Jan 24, 2020
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Vec<NonCopy>in for loop #68424 (Suggest borrowingVec<NonCopy>in for loop)std::iter::Skip::count#68469 (Avoid overflow instd::iter::Skip::count)unused_parensfor block return values #68479 (Implementunused_parensfor block return values)Failed merges:
r? @ghost