Split `join_codegen_and_link()` into two steps by 0dvictor · Pull Request #68601 · rust-lang/rust

0dvictor · 2020-01-28T14:12:56Z

join_codegen_and_link() is split to join_codegen() and link().

rust-highfive · 2020-01-28T14:12:59Z

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

0dvictor · 2020-01-28T14:18:06Z

@bjorn3 do you mind take a look, since you suggested similar, if not same, refactoring in #67195 and #68487.

0dvictor · 2020-01-28T14:18:35Z

r? @tmandry

rust-highfive · 2020-01-28T15:59:08Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-28T14:13:37.8437248Z ========================== Starting Command Output ===========================
2020-01-28T14:13:37.8439177Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/56d564dc-97d2-4f78-a812-1dc60f9a5226.sh
2020-01-28T14:13:37.8439216Z 2020-01-28T14:13:37.8442395Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-28T14:13:37.8449642Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68601/merge to s
2020-01-28T14:13:37.8451393Z Task : Get sources
2020-01-28T14:13:37.8451432Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-28T14:13:37.8451468Z Version : 1.0.0
2020-01-28T14:13:37.8451505Z Author : Microsoft
---
2020-01-28T14:13:39.6336685Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-28T14:13:39.6347329Z ##[command]git config gc.auto 0
2020-01-28T14:13:39.6349699Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-28T14:13:39.6351646Z ##[command]git config --get-all http.proxy
2020-01-28T14:13:39.6357980Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68601/merge:refs/remotes/pull/68601/merge
---
2020-01-28T15:08:20.4199221Z .................................................................................................... 1700/9557
2020-01-28T15:08:25.4788391Z .................................................................................................... 1800/9557
2020-01-28T15:08:38.1765233Z .........................i.......................................................................... 1900/9557
2020-01-28T15:08:45.1049684Z .................................................................................................... 2000/9557
2020-01-28T15:08:59.4396102Z ...............iiiii................................................................................ 2100/9557
2020-01-28T15:09:09.8214047Z .................................................................................................... 2300/9557
2020-01-28T15:09:12.2988085Z .................................................................................................... 2400/9557
2020-01-28T15:09:17.3277887Z .................................................................................................... 2500/9557
2020-01-28T15:09:37.8839091Z .................................................................................................... 2600/9557
---
2020-01-28T15:12:13.6942361Z .................................................................................................... 4800/9557
2020-01-28T15:12:18.7475868Z ...........................................................i...............i........................ 4900/9557
2020-01-28T15:12:26.5034628Z .................................................................................................... 5000/9557
2020-01-28T15:12:34.8359462Z .................................................................................................... 5100/9557
2020-01-28T15:12:39.6411332Z ..i................................................................................................. 5200/9557
2020-01-28T15:12:50.4531581Z ...........................................................................ii.ii........i...i....... 5300/9557
2020-01-28T15:12:58.9544869Z .............i...................................................................................... 5500/9557
2020-01-28T15:13:08.8031928Z .................................................................................................... 5600/9557
2020-01-28T15:13:15.7234186Z ..............................................................i..................................... 5700/9557
2020-01-28T15:13:22.1905452Z .................................................................................................... 5800/9557
2020-01-28T15:13:22.1905452Z .................................................................................................... 5800/9557
2020-01-28T15:13:30.0370394Z .................................................................................................... 5900/9557
2020-01-28T15:13:38.7284221Z .....................................................ii...i..ii...........i......................... 6000/9557
2020-01-28T15:14:00.5538870Z .................................................................................................... 6200/9557
2020-01-28T15:14:05.3296144Z .................................................................................................... 6300/9557
2020-01-28T15:14:05.3296144Z .................................................................................................... 6300/9557
2020-01-28T15:14:09.7803729Z .................................................................................i..ii.............. 6400/9557
2020-01-28T15:14:35.8734178Z .................................................................................................... 6600/9557
2020-01-28T15:14:41.3211884Z .........................................................i.......................................... 6700/9557
2020-01-28T15:14:43.5096806Z .................................................................................................... 6800/9557
2020-01-28T15:14:45.7527910Z ........................................................i........................................... 6900/9557
---
2020-01-28T15:16:28.7831664Z .................................................................................................... 7600/9557
2020-01-28T15:16:34.1068268Z .................................................................................................... 7700/9557
2020-01-28T15:16:40.6671582Z .................................................................................................... 7800/9557
2020-01-28T15:16:51.7525940Z .................................................................................................... 7900/9557
2020-01-28T15:16:58.0579071Z ............iiiiiii................................................................................. 8000/9557
2020-01-28T15:17:12.7654731Z .................................................................................................... 8200/9557
2020-01-28T15:17:23.7023880Z .................................................................................................... 8300/9557
2020-01-28T15:17:37.1568513Z .................................................................................................... 8400/9557
2020-01-28T15:17:43.9101506Z .................................................................................................... 8500/9557
---
2020-01-28T15:20:01.7954169Z finished in 7.026
2020-01-28T15:20:01.8153611Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-28T15:20:02.0087522Z 2020-01-28T15:20:02.0087766Z running 169 tests
2020-01-28T15:20:04.9710888Z iiii......i........ii..iiii...i....i...........i............i..i..................i....i............ 100/169
2020-01-28T15:20:07.1881684Z i.i.i...iii..iiiiiiiiii.......................iii............ii......
2020-01-28T15:20:07.1882280Z 2020-01-28T15:20:07.1887817Z finished in 5.373
2020-01-28T15:20:07.2097714Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-28T15:20:07.3927510Z ---
2020-01-28T15:20:09.3645699Z finished in 2.155
2020-01-28T15:20:09.3859358Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-28T15:20:09.5459350Z 2020-01-28T15:20:09.5460280Z running 9 tests
2020-01-28T15:20:09.5461844Z iiiiiiiii
2020-01-28T15:20:09.5462293Z 2020-01-28T15:20:09.5465222Z finished in 0.160
2020-01-28T15:20:09.5683289Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-28T15:20:09.7693165Z ---
2020-01-28T15:20:29.3560996Z finished in 19.787
2020-01-28T15:20:29.3803659Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-28T15:20:29.5736258Z 2020-01-28T15:20:29.5737675Z running 116 tests
2020-01-28T15:20:43.3871296Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-01-28T15:20:45.1403112Z ....iiii.....ii.
2020-01-28T15:20:45.1405394Z 2020-01-28T15:20:45.1407708Z finished in 15.760
2020-01-28T15:20:45.1416148Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-28T15:20:45.1416526Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-01-28T15:33:33.3053287Z 2020-01-28T15:33:33.3054154Z Doc-tests core
2020-01-28T15:33:37.9021428Z 2020-01-28T15:33:37.9022374Z running 2467 tests
2020-01-28T15:33:46.9523721Z ......iiiii......................................................................................... 100/2467
2020-01-28T15:33:55.4867144Z ..................................................................................ii................ 200/2467
2020-01-28T15:34:15.5503929Z .................i.................................................................................. 400/2467
2020-01-28T15:34:15.5503929Z .................i.................................................................................. 400/2467
2020-01-28T15:34:24.6166060Z ..................................................................i..i..................iiii........ 500/2467
2020-01-28T15:34:40.7080752Z .................................................................................................... 700/2467
2020-01-28T15:34:48.7266979Z .................................................................................................... 800/2467
2020-01-28T15:34:57.0506206Z .................................................................................................... 900/2467
2020-01-28T15:35:05.4543642Z .................................................................................................... 1000/2467
---
2020-01-28T15:38:25.0593833Z .................................................................................................... 500/760
2020-01-28T15:38:25.1080428Z .................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2741:22
2020-01-28T15:38:25.1095594Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2778:21
2020-01-28T15:38:25.1097736Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2766:17
2020-01-28T15:38:25.1118879Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2645:13
2020-01-28T15:38:25.5653196Z ..........................................thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1997..:22
2020-01-28T15:38:25.5660758Z ...thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2022:17
2020-01-28T15:38:25.5682441Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2034:21
2020-01-28T15:38:25.5788038Z .................. 600/760
2020-01-28T15:38:27.6082005Z ...................thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:633:13
2020-01-28T15:38:27.6088725Z ..thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:587:13
2020-01-28T15:38:27.6105860Z ........thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:563:13
---
2020-01-28T15:38:36.6160823Z 2020-01-28T15:38:36.6163000Z running 1003 tests
2020-01-28T15:38:54.0658296Z i................................................................................................... 100/1003
2020-01-28T15:39:04.3588838Z .................................................................................................... 200/1003
2020-01-28T15:39:11.3124118Z ..................iii......i......i...i......i...................................................... 300/1003
2020-01-28T15:39:16.1524463Z .................................................................................................... 400/1003
2020-01-28T15:39:22.7499225Z ..........................................i..i.....................................ii............... 500/1003
2020-01-28T15:39:34.8980734Z .................................................................................................... 700/1003
2020-01-28T15:39:34.8980734Z .................................................................................................... 700/1003
2020-01-28T15:39:41.2675006Z .............................iiii................................................................... 800/1003
2020-01-28T15:39:54.6269443Z .................................................................................................... 900/1003
2020-01-28T15:40:01.2503552Z ...................................................iiii............................................. 1000/1003
2020-01-28T15:40:01.3473338Z test result: ok. 983 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-01-28T15:40:01.3473754Z 2020-01-28T15:40:01.3606834Z finished in 164.979
2020-01-28T15:40:01.3616848Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-01-28T15:57:50.5104807Z finished in 37.094
2020-01-28T15:57:50.5470471Z Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-28T15:57:50.7573105Z 2020-01-28T15:57:50.7573799Z running 204 tests
2020-01-28T15:58:19.7222993Z .....................i...ii...................................F.................................i... 100/204
2020-01-28T15:58:53.9665302Z ....................................iiiiii......i............iii.................................... 200/204
2020-01-28T15:58:54.9020980Z .i..
2020-01-28T15:58:54.9031381Z 2020-01-28T15:58:54.9031980Z ---- [run-make] run-make-fulldeps/hotplug_codegen_backend stdout ----
2020-01-28T15:58:54.9032020Z 2020-01-28T15:58:54.9035676Z error: make failed
2020-01-28T15:58:54.9035676Z error: make failed
2020-01-28T15:58:54.9036041Z status: exit code: 2
2020-01-28T15:58:54.9036128Z command: "make"
2020-01-28T15:58:54.9036216Z stdout:
2020-01-28T15:58:54.9036774Z ------------------------------------------
2020-01-28T15:58:54.9038332Z /bin/echo || exit 0 # This test requires /bin/echo to exist
2020-01-28T15:58:54.9038430Z 2020-01-28T15:58:54.9039626Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend the_backend.rs --crate-name the_backend --crate-type dylib \
2020-01-28T15:58:54.9040063Z -o /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend/the_backend.dylib
2020-01-28T15:58:54.9040315Z Makefile:4: recipe for target 'all' failed
2020-01-28T15:58:54.9040590Z ------------------------------------------
2020-01-28T15:58:54.9040658Z stderr:
2020-01-28T15:58:54.9040886Z ------------------------------------------
2020-01-28T15:58:54.9040886Z ------------------------------------------
2020-01-28T15:58:54.9040954Z error[E0407]: method `join_codegen_and_link` is not a member of trait `CodegenBackend`
2020-01-28T15:58:54.9041193Z --> the_backend.rs:74:5
2020-01-28T15:58:54.9041291Z 74 | / fn join_codegen_and_link(
2020-01-28T15:58:54.9041356Z 75 | | &self,
2020-01-28T15:58:54.9041356Z 75 | | &self,
2020-01-28T15:58:54.9041406Z 76 | | ongoing_codegen: Box<dyn Any>,
2020-01-28T15:58:54.9041516Z ... |
2020-01-28T15:58:54.9041562Z 95 | | Ok(())
2020-01-28T15:58:54.9041608Z 96 | | }
2020-01-28T15:58:54.9041659Z | |_____^ not a member of trait `CodegenBackend`
2020-01-28T15:58:54.9041659Z | |_____^ not a member of trait `CodegenBackend`
2020-01-28T15:58:54.9041709Z 2020-01-28T15:58:54.9041945Z warning: ignoring --out-dir flag due to -o flag
2020-01-28T15:58:54.9041988Z 2020-01-28T15:58:54.9042040Z error[E0046]: not all trait items implemented, missing: `join_codegen`, `link`
2020-01-28T15:58:54.9042274Z --> the_backend.rs:44:1
2020-01-28T15:58:54.9042573Z 44 | impl CodegenBackend for TheBackend {
2020-01-28T15:58:54.9042573Z 44 | impl CodegenBackend for TheBackend {
2020-01-28T15:58:54.9042652Z | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `join_codegen`, `link` in implementation
2020-01-28T15:58:54.9042701Z |
2020-01-28T15:58:54.9043218Z = help: implement the missing item: `fn join_codegen(&self, _: std::boxed::Box<(dyn std::any::Any + 'static)>, _: &rustc::rustc_session::Session, _: &rustc::dep_graph::DepGraph) -> std::result::Result<std::boxed::Box<(dyn std::any::Any + 'static)>, rustc::util::common::ErrorReported> { unimplemented!() }`
2020-01-28T15:58:54.9043734Z = help: implement the missing item: `fn link(&self, _: &rustc::rustc_session::Session, _: std::boxed::Box<(dyn std::any::Any + 'static)>, _: &rustc::rustc_session::config::OutputFilenames) -> std::result::Result<(), rustc::util::common::ErrorReported> { unimplemented!() }`
2020-01-28T15:58:54.9043941Z error: aborting due to 2 previous errors
2020-01-28T15:58:54.9043974Z 2020-01-28T15:58:54.9044023Z Some errors have detailed explanations: E0046, E0407.
2020-01-28T15:58:54.9044305Z For more information about an error, try `rustc --explain E0046`.
2020-01-28T15:58:54.9044305Z For more information about an error, try `rustc --explain E0046`.
2020-01-28T15:58:54.9044377Z make: *** [all] Error 1
2020-01-28T15:58:54.9044638Z ------------------------------------------
2020-01-28T15:58:54.9044671Z 2020-01-28T15:58:54.9044697Z 2020-01-28T15:58:54.9044741Z ---
2020-01-28T15:58:54.9045678Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:349:22
2020-01-28T15:58:54.9045764Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-01-28T15:58:54.9045830Z 2020-01-28T15:58:54.9045859Z 2020-01-28T15:58:54.9064355Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/run-make-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-make" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "cc" "--cxx" "c++" "--cflags" "-ffunction-sections -fdata-sections -fPIC -m64" "--llvm-components" "aarch64 aarch64asmparser aarch64asmprinter aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpuasmprinter amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armasmprinter armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrasmprinter avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitwriter bpf bpfasmparser bpfasmprinter bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader lanai lanaiasmparser lanaiasmprinter lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mcdisassembler mcjit mcparser mips mipsasmparser mipsasmprinter mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmprinter msp430codegen msp430desc msp430info native nativecodegen nvptx nvptxasmprinter nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpcasmprinter powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata runtimedyld scalaropts selectiondag sparc sparcasmparser sparcasmprinter sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzasmprinter systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target transformutils vectorize webassembly webassemblyasmparser webassemblyasmprinter webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86asmprinter x86codegen x86desc x86disassembler x86info x86utils xcore xcoreasmprinter xcorecodegen xcoredesc xcoredisassembler xcoreinfo" "--llvm-cxxflags" "-I/usr/lib/llvm-7/include -std=c++0x -fuse-ld=gold -Wl,--no-keep-files-mapped -Wl,--no-map-whole-files -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-sections -O2 -DNDEBUG -fno-exceptions -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS" "--ar" "ar" "--llvm-bin-dir" "/usr/lib/llvm-7/bin" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-28T15:58:54.9065413Z 2020-01-28T15:58:54.9065447Z 2020-01-28T15:58:54.9068315Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-28T15:58:54.9068390Z Build completed unsuccessfully in 1:39:08
2020-01-28T15:58:54.9068390Z Build completed unsuccessfully in 1:39:08
2020-01-28T15:58:54.9124096Z == clock drift check ==
2020-01-28T15:58:54.9141554Z local time: Tue Jan 28 15:58:54 UTC 2020
2020-01-28T15:58:55.2084299Z network time: Tue, 28 Jan 2020 15:58:55 GMT
2020-01-28T15:58:55.2090779Z == end clock drift check ==
2020-01-28T15:58:56.5452472Z 2020-01-28T15:58:56.5544308Z ##[error]Bash exited with code '1'.
2020-01-28T15:58:56.5557017Z ##[section]Finishing: Run build
2020-01-28T15:58:56.5576465Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68601/merge to s
2020-01-28T15:58:56.5578407Z Task : Get sources
2020-01-28T15:58:56.5578460Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-28T15:58:56.5578529Z Version : 1.0.0
2020-01-28T15:58:56.5578576Z Author : Microsoft
2020-01-28T15:58:56.5578576Z Author : Microsoft
2020-01-28T15:58:56.5578628Z Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-28T15:58:56.5578700Z ==============================================================================
2020-01-28T15:58:56.9809720Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-28T15:58:56.9849370Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68601/merge to s
2020-01-28T15:58:56.9956264Z Cleaning up task key
2020-01-28T15:58:56.9957192Z Start cleaning up orphan processes.
2020-01-28T15:58:57.0057713Z Terminate orphan process: pid (3515) (python)
2020-01-28T15:58:57.0854626Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bjorn3

Just a few comments, but looks great otherwise.

bjorn3 · 2020-01-28T17:53:42Z

This drops dep_graph before linking now, so this should reduce memory consumption during linking.

bjorn3 · 2020-01-28T17:55:21Z

You will need to update the run-make-fulldeps/hotplug_codegen_backend test.

tmandry · 2020-01-28T19:54:20Z

This is introducing a stall inside what looks kind of like an accessor, when there wasn't one before. I think there should be a comment on the function, at least. Also, double check that this doesn't seem like a problem at any call sites.

Good point, and after a second thought, I think it makes more sense to keep join_codegen in where join_codegen_and_link was, so that behavior changes should be minimized.
I add a commit to the PR moving join_codegen into Linker::link to demonstrate the change, could you take a look?

BTW, we can still drop dep_graph before calling backend to link, so we should reduce similar memory consumption during linking, as if we join codegen inside Queries::linker().

rust-highfive · 2020-01-29T05:23:35Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-29T05:10:33.1614511Z ========================== Starting Command Output ===========================
2020-01-29T05:10:33.1616885Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/3af3b0f2-cc82-4923-a5dd-15f9e4ec31fb.sh
2020-01-29T05:10:33.1779110Z 2020-01-29T05:10:33.1867734Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-29T05:10:33.1872228Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68601/merge to s
2020-01-29T05:10:33.1873394Z Task : Get sources
2020-01-29T05:10:33.1873419Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-29T05:10:33.1873444Z Version : 1.0.0
2020-01-29T05:10:33.1873501Z Author : Microsoft
---
2020-01-29T05:10:34.0033709Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-29T05:10:34.0042021Z ##[command]git config gc.auto 0
2020-01-29T05:10:34.0043665Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-29T05:10:34.0045643Z ##[command]git config --get-all http.proxy
2020-01-29T05:10:34.0138283Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68601/merge:refs/remotes/pull/68601/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-29T05:50:50Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-29T05:30:14.7822716Z ========================== Starting Command Output ===========================
2020-01-29T05:30:14.7839439Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/adf21447-1729-41f3-9eee-41f736845a06.sh
2020-01-29T05:30:14.8055175Z 2020-01-29T05:30:14.8144491Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-29T05:30:14.8150370Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68601/merge to s
2020-01-29T05:30:14.8152020Z Task : Get sources
2020-01-29T05:30:14.8152052Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-29T05:30:14.8152085Z Version : 1.0.0
2020-01-29T05:30:14.8152155Z Author : Microsoft
---
2020-01-29T05:30:15.6343019Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-29T05:30:15.6420777Z ##[command]git config gc.auto 0
2020-01-29T05:30:15.6487497Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-29T05:30:15.6540910Z ##[command]git config --get-all http.proxy
2020-01-29T05:30:15.6670805Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68601/merge:refs/remotes/pull/68601/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2020-01-29T08:12:34Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-01-29T06:31:25.4054587Z ========================== Starting Command Output ===========================
2020-01-29T06:31:25.4286229Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/68499c36-e8eb-4c19-8fed-fccff8c0e8ee.sh
2020-01-29T06:31:25.4286450Z 2020-01-29T06:31:25.4289892Z ##[section]Finishing: Disable git automatic line ending conversion
2020-01-29T06:31:25.4296157Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68601/merge to s
2020-01-29T06:31:25.4297647Z Task : Get sources
2020-01-29T06:31:25.4297679Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-29T06:31:25.4297746Z Version : 1.0.0
2020-01-29T06:31:25.4297777Z Author : Microsoft
---
2020-01-29T06:31:26.4113614Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-01-29T06:31:26.4128618Z ##[command]git config gc.auto 0
2020-01-29T06:31:26.4131977Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-01-29T06:31:26.4136895Z ##[command]git config --get-all http.proxy
2020-01-29T06:31:26.4146987Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68601/merge:refs/remotes/pull/68601/merge
---
2020-01-29T07:23:34.5792996Z .................................................................................................... 1700/9557
2020-01-29T07:23:39.3667790Z .................................................................................................... 1800/9557
2020-01-29T07:23:51.4071482Z .........................i.......................................................................... 1900/9557
2020-01-29T07:23:58.1075195Z .................................................................................................... 2000/9557
2020-01-29T07:24:11.6824857Z ...............iiiii................................................................................ 2100/9557
2020-01-29T07:24:20.9081774Z .................................................................................................... 2300/9557
2020-01-29T07:24:23.1614483Z .................................................................................................... 2400/9557
2020-01-29T07:24:28.1449077Z .................................................................................................... 2500/9557
2020-01-29T07:24:47.5595933Z .................................................................................................... 2600/9557
---
2020-01-29T07:27:10.7703088Z .................................................................................................... 4800/9557
2020-01-29T07:27:15.2858884Z ...........................................................i...............i........................ 4900/9557
2020-01-29T07:27:22.3221713Z .................................................................................................... 5000/9557
2020-01-29T07:27:29.7124428Z .................................................................................................... 5100/9557
2020-01-29T07:27:34.1307800Z ..i................................................................................................. 5200/9557
2020-01-29T07:27:44.6822069Z ...........................................................................ii.ii........i...i....... 5300/9557
2020-01-29T07:27:52.9321513Z .............i...................................................................................... 5500/9557
2020-01-29T07:28:02.3382148Z .................................................................................................... 5600/9557
2020-01-29T07:28:08.4280357Z ..............................................................i..................................... 5700/9557
2020-01-29T07:28:15.2783429Z .................................................................................................... 5800/9557
2020-01-29T07:28:15.2783429Z .................................................................................................... 5800/9557
2020-01-29T07:28:22.8986770Z .................................................................................................... 5900/9557
2020-01-29T07:28:31.1779971Z .....................................................ii...i..ii...........i......................... 6000/9557
2020-01-29T07:28:51.5839466Z .................................................................................................... 6200/9557
2020-01-29T07:28:58.5444510Z .................................................................................................... 6300/9557
2020-01-29T07:28:58.5444510Z .................................................................................................... 6300/9557
2020-01-29T07:29:06.3501278Z .................................................................................i..ii.............. 6400/9557
2020-01-29T07:29:30.8311427Z .................................................................................................... 6600/9557
2020-01-29T07:29:35.6728758Z .........................................................i.......................................... 6700/9557
2020-01-29T07:29:37.6874654Z .................................................................................................... 6800/9557
2020-01-29T07:29:39.6829104Z ........................................................i........................................... 6900/9557
---
2020-01-29T07:31:14.2066916Z .................................................................................................... 7600/9557
2020-01-29T07:31:19.0855542Z .................................................................................................... 7700/9557
2020-01-29T07:31:25.2777782Z .................................................................................................... 7800/9557
2020-01-29T07:31:35.1401511Z .................................................................................................... 7900/9557
2020-01-29T07:31:40.8825281Z ............iiiiiii................................................................................. 8000/9557
2020-01-29T07:31:54.0624739Z .................................................................................................... 8200/9557
2020-01-29T07:32:03.8165717Z .................................................................................................... 8300/9557
2020-01-29T07:32:15.8663664Z .................................................................................................... 8400/9557
2020-01-29T07:32:22.0244655Z .................................................................................................... 8500/9557
---
2020-01-29T07:34:32.3495181Z finished in 6.901
2020-01-29T07:34:32.3666077Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T07:34:33.0666364Z 2020-01-29T07:34:33.0669999Z running 169 tests
2020-01-29T07:34:35.2300557Z iiii......i........ii..iiii...i....i...........i............i..i..................i....i............ 100/169
2020-01-29T07:34:37.3625535Z i.i.i...iii..iiiiiiiiii.......................iii............ii......
2020-01-29T07:34:37.3626083Z 2020-01-29T07:34:37.3628598Z finished in 4.996
2020-01-29T07:34:37.3792408Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T07:34:37.5311920Z ---
2020-01-29T07:34:39.4010101Z finished in 2.021
2020-01-29T07:34:39.4192404Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T07:34:40.0677373Z 2020-01-29T07:34:40.0677485Z running 9 tests
2020-01-29T07:34:40.0678244Z iiiiiiiii
2020-01-29T07:34:40.0678577Z 2020-01-29T07:34:40.0678638Z finished in 0.144
2020-01-29T07:34:40.0678937Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T07:34:40.0678973Z ---
2020-01-29T07:34:58.5111092Z finished in 18.929
2020-01-29T07:34:58.5291189Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T07:34:59.5711994Z 2020-01-29T07:34:59.5712116Z running 116 tests
2020-01-29T07:35:12.6231973Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-01-29T07:35:14.5873649Z ....iiii.....ii.
2020-01-29T07:35:14.5874153Z 2020-01-29T07:35:14.5878740Z finished in 16.058
2020-01-29T07:35:14.5879657Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T07:35:14.5879997Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-01-29T07:47:41.2096228Z 2020-01-29T07:47:41.2107108Z Doc-tests core
2020-01-29T07:47:45.6376483Z 2020-01-29T07:47:45.6378376Z running 2467 tests
2020-01-29T07:47:54.0286022Z ......iiiii......................................................................................... 100/2467
2020-01-29T07:48:02.2643318Z ..................................................................................ii................ 200/2467
2020-01-29T07:48:21.6459107Z .................i.................................................................................. 400/2467
2020-01-29T07:48:21.6459107Z .................i.................................................................................. 400/2467
2020-01-29T07:48:30.5762634Z ..................................................................i..i..................iiii........ 500/2467
2020-01-29T07:48:45.6857567Z .................................................................................................... 700/2467
2020-01-29T07:48:53.7122110Z .................................................................................................... 800/2467
2020-01-29T07:49:01.6012520Z .................................................................................................... 900/2467
2020-01-29T07:49:09.4485260Z .................................................................................................... 1000/2467
---
2020-01-29T07:52:19.6405418Z ....thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:2034:21
2020-01-29T07:52:19.6415211Z thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', src/libstd/sync/mpsc/mod.rs:2022:17
2020-01-29T07:52:19.6444334Z .......thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: RecvError', src/libstd/sync/mpsc/mod.rs:1916:13
2020-01-29T07:52:19.6938248Z ................... 600/760
2020-01-29T07:52:21.7194027Z ...................thread '..<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:633:13
2020-01-29T07:52:21.7201788Z ...thread '<unnamed>' panicked at 'test panic in inner thread to poison mutex', src/libstd/sync/mutex.rs:563:13
2020-01-29T07:52:21.7203113Z thread '<unnamed>' panicked at 'explicit panic', src/libstd/sync/mutex.rs:694:13
2020-01-29T07:52:21.7207890Z ....thread '<unnamed>' panicked at 'assertion failed: `(left == right)`
2020-01-29T07:52:21.7207998Z left: `1`,
---
2020-01-29T07:52:30.6329810Z 2020-01-29T07:52:30.6330068Z running 1003 tests
2020-01-29T07:52:47.4181082Z i................................................................................................... 100/1003
2020-01-29T07:52:56.5482205Z .................................................................................................... 200/1003
2020-01-29T07:53:03.0448101Z ..................iii......i......i...i......i...................................................... 300/1003
2020-01-29T07:53:07.6050770Z .................................................................................................... 400/1003
2020-01-29T07:53:13.8309022Z ..........................................i..i.....................................ii............... 500/1003
2020-01-29T07:53:25.6845052Z .................................................................................................... 700/1003
2020-01-29T07:53:25.6845052Z .................................................................................................... 700/1003
2020-01-29T07:53:31.6028600Z .............................iiii................................................................... 800/1003
2020-01-29T07:53:44.6011137Z .................................................................................................... 900/1003
2020-01-29T07:53:50.8760920Z ...................................................iiii............................................. 1000/1003
2020-01-29T07:53:50.9310242Z test result: ok. 983 passed; 0 failed; 20 ignored; 0 measured; 0 filtered out
2020-01-29T07:53:50.9310815Z 2020-01-29T07:53:50.9407157Z finished in 156.044
2020-01-29T07:53:50.9418478Z Testing term stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
2020-01-29T08:11:22.9989050Z finished in 37.167
2020-01-29T08:11:23.0272667Z Check compiletest suite=run-make-fulldeps mode=run-make (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-01-29T08:11:23.2372437Z 2020-01-29T08:11:23.2372953Z running 204 tests
2020-01-29T08:11:52.4383132Z .....................i...ii..................................F..................................i... 100/204
2020-01-29T08:12:27.5096806Z ....................................iiiiii......i............iii.................................... 200/204
2020-01-29T08:12:27.8812948Z .i..
2020-01-29T08:12:27.8822864Z thread '
2020-01-29T08:12:27.8823209Z ---- [run-make] run-make-fulldeps/hotplug_codegen_backend stdout ----
2020-01-29T08:12:27.8823252Z 2020-01-29T08:12:27.8823324Z error: make failed
2020-01-29T08:12:27.8823324Z error: make failed
2020-01-29T08:12:27.8823364Z status: exit code: 2
2020-01-29T08:12:27.8823402Z command: "make"
2020-01-29T08:12:27.8823458Z stdout:
2020-01-29T08:12:27.8823675Z ------------------------------------------
2020-01-29T08:12:27.8823725Z /bin/echo || exit 0 # This test requires /bin/echo to exist
2020-01-29T08:12:27.8823982Z 2020-01-29T08:12:27.8824896Z LD_LIBRARY_PATH="/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend:/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-bootstrap-tools/x86_64-unknown-linux-gnu/release/deps:/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/lib" '/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc' --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend -L /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend the_backend.rs --crate-name the_backend --crate-type dylib \
2020-01-29T08:12:27.8825263Z -o /checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps/hotplug_codegen_backend/hotplug_codegen_backend/the_backend.dylib
2020-01-29T08:12:27.8825469Z Makefile:4: recipe for target 'all' failed
2020-01-29T08:12:27.8825733Z ------------------------------------------
2020-01-29T08:12:27.8825776Z stderr:
2020-01-29T08:12:27.8825968Z ------------------------------------------
2020-01-29T08:12:27.8825968Z ------------------------------------------
2020-01-29T08:12:27.8826036Z error[E0407]: method `join_codegen_and_link` is not a member of trait `CodegenBackend`
2020-01-29T08:12:27.8826228Z --> the_backend.rs:74:5
2020-01-29T08:12:27.8826492Z 74 | / fn join_codegen_and_link(
2020-01-29T08:12:27.8826532Z 75 | | &self,
2020-01-29T08:12:27.8826532Z 75 | | &self,
2020-01-29T08:12:27.8826570Z 76 | | ongoing_codegen: Box<dyn Any>,
2020-01-29T08:12:27.8826662Z ... |
2020-01-29T08:12:27.8826697Z 95 | | Ok(())
2020-01-29T08:12:27.8826732Z 96 | | }
2020-01-29T08:12:27.8826787Z | |_____^ not a member of trait `CodegenBackend`
2020-01-29T08:12:27.8826787Z | |_____^ not a member of trait `CodegenBackend`
2020-01-29T08:12:27.8826815Z 2020-01-29T08:12:27.8827049Z warning: ignoring --out-dir flag due to -o flag
2020-01-29T08:12:27.8827088Z 2020-01-29T08:12:27.8827145Z error[E0046]: not all trait items implemented, missing: `join_codegen`, `link`
2020-01-29T08:12:27.8827335Z --> the_backend.rs:44:1
2020-01-29T08:12:27.8827427Z 44 | impl CodegenBackend for TheBackend {
2020-01-29T08:12:27.8827427Z 44 | impl CodegenBackend for TheBackend {
2020-01-29T08:12:27.8827470Z | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `join_codegen`, `link` in implementation
2020-01-29T08:12:27.8827509Z |
2020-01-29T08:12:27.8827973Z = help: implement the missing item: `fn join_codegen(&self, _: std::boxed::Box<(dyn std::any::Any + 'static)>, _: &rustc::rustc_session::Session, _: &rustc::dep_graph::DepGraph) -> std::result::Result<std::boxed::Box<(dyn std::any::Any + 'static)>, rustc::util::common::ErrorReported> { unimplemented!() }`
2020-01-29T08:12:27.8828409Z = help: implement the missing item: `fn link(&self, _: &rustc::rustc_session::Session, _: std::boxed::Box<(dyn std::any::Any + 'static)>, _: &rustc::rustc_session::config::OutputFilenames) -> std::result::Result<(), rustc::util::common::ErrorReported> { unimplemented!() }`
2020-01-29T08:12:27.8828518Z error: aborting due to 2 previous errors
2020-01-29T08:12:27.8828541Z 2020-01-29T08:12:27.8828579Z Some errors have detailed explanations: E0046, E0407.
2020-01-29T08:12:27.8828814Z For more information about an error, try `rustc --explain E0046`.
2020-01-29T08:12:27.8828814Z For more information about an error, try `rustc --explain E0046`.
2020-01-29T08:12:27.8828859Z make: *** [all] Error 1
2020-01-29T08:12:27.8829166Z ------------------------------------------
2020-01-29T08:12:27.8829223Z 2020-01-29T08:12:27.8829246Z 2020-01-29T08:12:27.8829268Z ---
2020-01-29T08:12:27.8834643Z main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-01-29T08:12:27.8835435Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-01-29T08:12:27.8843414Z 2020-01-29T08:12:27.8843480Z 2020-01-29T08:12:27.8847436Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/run-make-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-make-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-make" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "cc" "--cxx" "c++" "--cflags" "-ffunction-sections -fdata-sections -fPIC -m64" "--llvm-components" "aarch64 aarch64asmparser aarch64asmprinter aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpuasmprinter amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armasmprinter armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrasmprinter avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitwriter bpf bpfasmparser bpfasmprinter bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader lanai lanaiasmparser lanaiasmprinter lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mcdisassembler mcjit mcparser mips mipsasmparser mipsasmprinter mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmprinter msp430codegen msp430desc msp430info native nativecodegen nvptx nvptxasmprinter nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpcasmprinter powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata runtimedyld scalaropts selectiondag sparc sparcasmparser sparcasmprinter sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzasmprinter systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target transformutils vectorize webassembly webassemblyasmparser webassemblyasmprinter webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86asmprinter x86codegen x86desc x86disassembler x86info x86utils xcore xcoreasmprinter xcorecodegen xcoredesc xcoredisassembler xcoreinfo" "--ar" "ar" "--llvm-bin-dir" "/usr/lib/llvm-7/bin" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-01-29T08:12:27.8848172Z 2020-01-29T08:12:27.8848199Z 2020-01-29T08:12:27.8900472Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-01-29T08:12:27.8900541Z Build completed unsuccessfully in 1:35:11
2020-01-29T08:12:27.8900541Z Build completed unsuccessfully in 1:35:11
2020-01-29T08:12:27.8903693Z == clock drift check ==
2020-01-29T08:12:27.8923437Z local time: Wed Jan 29 08:12:27 UTC 2020
2020-01-29T08:12:28.0403251Z network time: Wed, 29 Jan 2020 08:12:28 GMT
2020-01-29T08:12:28.0405535Z == end clock drift check ==
2020-01-29T08:12:28.7573036Z 2020-01-29T08:12:28.7669093Z ##[error]Bash exited with code '1'.
2020-01-29T08:12:28.7681918Z ##[section]Finishing: Run build
2020-01-29T08:12:28.7711826Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68601/merge to s
2020-01-29T08:12:28.7713908Z Task : Get sources
2020-01-29T08:12:28.7713954Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-01-29T08:12:28.7714175Z Version : 1.0.0
2020-01-29T08:12:28.7714215Z Author : Microsoft
2020-01-29T08:12:28.7714215Z Author : Microsoft
2020-01-29T08:12:28.7714419Z Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-01-29T08:12:28.7714482Z ==============================================================================
2020-01-29T08:12:29.1588968Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-01-29T08:12:29.1632986Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/68601/merge to s
2020-01-29T08:12:29.1732881Z Cleaning up task key
2020-01-29T08:12:29.1733556Z Start cleaning up orphan processes.
2020-01-29T08:12:29.1866151Z Terminate orphan process: pid (7190) (python)
2020-01-29T08:12:29.2131229Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

tmandry · 2020-02-03T23:01:18Z

@bors r+

bors · 2020-02-03T23:01:20Z

📌 Commit ff1a5a1f613a9ca42fa0ddcaf23da086f0cae390 has been approved by tmandry

`join_codegen_and_link()` is split to `join_codegen()` and `link()`.

tmandry · 2020-02-04T00:27:54Z

@bors r+

bors · 2020-02-04T00:27:55Z

📌 Commit ae51d2b has been approved by tmandry

bors · 2020-02-04T05:49:02Z

⌛ Testing commit ae51d2b with merge fc07615...

Split `join_codegen_and_link()` into two steps `join_codegen_and_link()` is split to `join_codegen()` and `link()`.

bors · 2020-02-04T09:03:23Z

☀️ Test successful - checks-azure
Approved by: tmandry
Pushing fc07615 to master...

rust-highfive assigned varkor Jan 28, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2020

0dvictor mentioned this pull request Jan 28, 2020
[experiment] Support linking from a .rlink file #68487
Merged

rust-highfive assigned tmandry and unassigned varkor Jan 28, 2020

bjorn3 approved these changes Jan 28, 2020
View reviewed changes

tmandry reviewed Jan 28, 2020
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2020

Split join_codegen_and_link() into two steps
ae51d2b
`join_codegen_and_link()` is split to `join_codegen()` and `link()`.

bors added a commit that referenced this pull request Feb 4, 2020
Auto merge of#68601- 0dvictor:split, r=tmandry
fc07615
Split `join_codegen_and_link()` into two steps `join_codegen_and_link()` is split to `join_codegen()` and `link()`.

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 4, 2020

bors merged commit ae51d2b into rust-lang:masterFeb 4, 2020

0dvictor deleted the split branch February 4, 2020 10:38

Uh oh!

Uh oh!

Conversation

0dvictor commented Jan 28, 2020

Uh oh!

rust-highfive commented Jan 28, 2020

Uh oh!

0dvictor commented Jan 28, 2020

Uh oh!

0dvictor commented Jan 28, 2020

Uh oh!

rust-highfive commented Jan 28, 2020

Uh oh!

bjorn3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bjorn3Jan 28, 2020

Choose a reason for hiding this comment

Uh oh!

bjorn3 commented Jan 28, 2020

Uh oh!

tmandryJan 28, 2020

Choose a reason for hiding this comment

Uh oh!

0dvictorJan 29, 2020

Choose a reason for hiding this comment

Uh oh!

0dvictorJan 29, 2020

Choose a reason for hiding this comment

Uh oh!

rust-highfive commented Jan 29, 2020

Uh oh!

rust-highfive commented Jan 29, 2020

Uh oh!

rust-highfive commented Jan 29, 2020

Uh oh!

tmandry commented Feb 3, 2020

Uh oh!

bors commented Feb 3, 2020

Uh oh!

tmandry commented Feb 4, 2020

Uh oh!

bors commented Feb 4, 2020

Uh oh!

bors commented Feb 4, 2020

Uh oh!

bors commented Feb 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants