Uh oh!
There was an error while loading. Please reload this page.
Remove incorrect debug assertions from catch_unwind - #68698
Merged
Conversation
Previously the debug assertions in the implementation of catch_unwind used to verify consistency of the panic count by checking that the count is zero just before leaving the function. This incorrectly assumed that no panic was in progress when entering `catch_unwind`.
Mark-Simulacrum
commented
Jan 31, 2020
Member
I believe this is correct but going to r? @Amanieu just in case here. |
Amanieu
commented
Jan 31, 2020
Member
@bors r+ rollup |
bors
commented
Jan 31, 2020
Collaborator
📌 Commit 80c3bec has been approved by |
bors
commented
Feb 1, 2020
Collaborator
bors added a commit
that referenced
this pull request
Feb 1, 2020
Remove incorrect debug assertions from catch_unwind Previously the debug assertions in the implementation of catch_unwind used to verify consistency of the panic count by checking that the count is zero just before leaving the function. This incorrectly assumed that no panic was in progress when entering `catch_unwind`. Fixes#68696.
This was referenced Feb 1, 2020
bors
commented
Feb 1, 2020
Collaborator
☀️ Test successful - checks-azure |
rust-highfive
commented
Feb 1, 2020
Contributor
📣 Toolstate changed by #68698! Tested on commit 6c0b779. 🎉 rustc-guide on linux: test-fail → test-pass (cc @JohnTitor@amanjeev@spastorino@mark-i-m, @rust-lang/infra). |
rust-highfive added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Feb 1, 2020
Tested on commit rust-lang/rust@6c0b779. Direct link to PR: <rust-lang/rust#68698> 🎉 rustc-guide on linux: test-fail → test-pass (cc @JohnTitor@amanjeev@spastorino@mark-i-m, @rust-lang/infra).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the debug assertions in the implementation of catch_unwind
used to verify consistency of the panic count by checking that the count
is zero just before leaving the function. This incorrectly assumed that
no panic was in progress when entering
catch_unwind.Fixes#68696.