Skip to content

Reexport static methods on structs & enums. - #6880

Merged
bors merged 2 commits into
rust-lang:incomingfrom
thomaslee:issue-6745
Jun 1, 2013
Merged

Reexport static methods on structs & enums.#6880
bors merged 2 commits into
rust-lang:incomingfrom
thomaslee:issue-6745

Conversation

@thomaslee

Copy link
Copy Markdown
Contributor

This fixes#6745, which itself relates to #4202. Slightly ham-fisted -- feel particularly funny about using the typeck phase to gather the base -> impl mapping, and the separate code paths for traits vs. "real" bases feels like it could be avoided -- but it seems to work.

As always, open to suggestions if there's a better way to accomplish what I'm trying to do.

@catamorphism r?

bors added a commit that referenced this pull request Jun 1, 2013
This fixes#6745, which itself relates to #4202. Slightly ham-fisted -- feel particularly funny about using the typeck phase to gather the base -> impl mapping, and the separate code paths for traits vs. "real" bases feels like it could be avoided -- but it seems to work.
As always, open to suggestions if there's a better way to accomplish what I'm trying to do.
@catamorphism r?
@borsbors closed this Jun 1, 2013
@bors
bors merged commit 4246694 into rust-lang:incomingJun 1, 2013
@thomaslee
thomaslee deleted the issue-6745 branch June 1, 2013 23:47
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
7047: Add force_show_panics flag for proc-macro bridge r=jonas-schievink a=edwin0cheng
rust-lang#75082 and rust-lang#76292 added a new flag in `proc_macro::Bridge` such that the ABI was changed. These ABI changing are the reason of some weird panics which caused rust-lang#6880 and maybe related to the panic mentioned in rust-lang#6820.
These changes are landed on rust stable 1.48 so I think it is okay to apply it now.
fixesrust-lang#6880
r @jonas-schievink Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@thomaslee@catamorphism@bors