Skip to content

On mismatched argument count point at arguments - #68877

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:point-at-params
Feb 20, 2020
Merged

On mismatched argument count point at arguments#68877
bors merged 1 commit into
rust-lang:masterfrom
estebank:point-at-params

Conversation

@estebank

@estebankestebank commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 6, 2020
petrochenkov
petrochenkov reviewed Feb 6, 2020
View reviewed changes
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2020
@bors

bors commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #68907) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkovpetrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 9, 2020
petrochenkov
petrochenkov reviewed Feb 9, 2020
View reviewed changes
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
Comment threadsrc/librustc_typeck/check/mod.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2020
@estebankestebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2020
@petrochenkov

petrochenkov commented Feb 11, 2020

Copy link
Copy Markdown
Contributor

r=me after squashing the commits

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2020
@estebank

estebank commented Feb 11, 2020

Copy link
Copy Markdown
ContributorAuthor

@bors r=petrochenkov

@bors

bors commented Feb 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 683ebc2 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 12, 2020
@Dylan-DPC
Rollup merge ofrust-lang#68877- estebank:point-at-params, r=petroch…
c33d531
…enkov
On mismatched argument count point at arguments
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Feb 12, 2020
Closed
@JohnTitor

JohnTitor commented Feb 12, 2020

Copy link
Copy Markdown
Member

Seems failed in #69085 (comment)
@bors r-

@borsbors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 12, 2020
@borsbors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 12, 2020
@estebank

estebank commented Feb 12, 2020

Copy link
Copy Markdown
ContributorAuthor

Blocked on rust-lang/cargo#7883

@estebankestebank added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2020
@estebank

estebank commented Feb 20, 2020

Copy link
Copy Markdown
ContributorAuthor

After #69265, @bors r=petrochenkov

@bors

bors commented Feb 20, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 683ebc2 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Feb 20, 2020
@bors

bors commented Feb 20, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 683ebc2 with merge 1a501dff214c1c084dbb2eb6bae8d9f159581a17...

@Centril

Centril commented Feb 20, 2020

Copy link
Copy Markdown
Contributor

@bors retry yielding to higher prio PR.

@bors

bors commented Feb 20, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 683ebc2 with merge 83e4e89b52d6c68719bf2a41a75839637c04819f...

@CentrilCentril mentioned this pull request Feb 20, 2020
Merged
@Centril

Centril commented Feb 20, 2020

Copy link
Copy Markdown
Contributor

@bors retry

bors added a commit that referenced this pull request Feb 20, 2020
@bors
Auto merge of#69325- Centril:rollup-vce2ko2, r=Centril
2c462a2
Rollup of 5 pull requests
Successful merges:
- #68877 (On mismatched argument count point at arguments)
- #69185 (Unify and improve const-prop lints)
- #69305 (Tweak binding lifetime suggestion text)
- #69311 (Clean up E0321 and E0322)
- #69317 (Fix broken link to the rustc guide)
Failed merges:
r? @ghost
@bors

bors commented Feb 20, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 683ebc2 with merge 2c462a2...

@bors
bors merged commit b680a5e into rust-lang:masterFeb 20, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@estebank@rust-highfive@bors@petrochenkov@JohnTitor@Centril