Skip to content

Move the hir().krate() method to a query and remove the Krate dep node - #68889

Merged
bors merged 6 commits into
rust-lang:masterfrom
Zoxc:hir-krate
Feb 7, 2020
Merged

Move the hir().krate() method to a query and remove the Krate dep node#68889
bors merged 6 commits into
rust-lang:masterfrom
Zoxc:hir-krate

Conversation

@Zoxc

@ZoxcZoxc commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

michaelwoerister
michaelwoerister reviewed Feb 6, 2020
View reviewed changes

@michaelwoeristermichaelwoerister left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed in detailed but looks good to me in general. I left a couple of comments below.

Comment threadsrc/librustc/query/mod.rs Outdated
Comment threadsrc/librustc/ty/context.rs
eddyb
eddyb reviewed Feb 6, 2020
View reviewed changes
Comment threadsrc/librustc/hir/mod.rs
@Zoxc

Zoxc commented Feb 6, 2020

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

rust-timer commented Feb 6, 2020

Copy link
Copy Markdown
Collaborator

Awaiting bors try build completion

@bors

bors commented Feb 6, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit a575495 with merge 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb...

eddyb
eddyb approved these changes Feb 6, 2020
View reviewed changes

@eddybeddyb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bors

bors commented Feb 6, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-azure
Build commit: 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb (8cb5f974b0fce803a3fac318d3a6f0f58f91efbb)

@rust-timer

rust-timer commented Feb 6, 2020

Copy link
Copy Markdown
Collaborator

Queued 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb with parent 1f8df25, future comparison URL.

@rust-timer

rust-timer commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator

Finished benchmarking try commit 8cb5f974b0fce803a3fac318d3a6f0f58f91efbb, comparison URL.

@Zoxc

Zoxc commented Feb 7, 2020

Copy link
Copy Markdown
ContributorAuthor

@bors r=eddyb

@bors

bors commented Feb 7, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit a575495 has been approved by eddyb

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 7, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 7, 2020
@Dylan-DPC
Rollup merge ofrust-lang#68889- Zoxc:hir-krate, r=eddyb
32a3871
Move the `hir().krate()` method to a query and remove the `Krate` dep node
r? @eddyb cc @michaelwoerister
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Feb 7, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 7, 2020
@Dylan-DPC
Rollup merge ofrust-lang#68889- Zoxc:hir-krate, r=eddyb
90f6267
Move the `hir().krate()` method to a query and remove the `Krate` dep node
r? @eddyb cc @michaelwoerister
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Feb 7, 2020
Merged
bors added a commit that referenced this pull request Feb 7, 2020
@bors
Auto merge of#68933- Dylan-DPC:rollup-akz13kj, r=Dylan-DPC
a29424a
Rollup of 7 pull requests
Successful merges:
- #68164 (Selectively disable sanitizer instrumentation)
- #68413 (Add GitHub issue templates)
- #68889 (Move the `hir().krate()` method to a query and remove the `Krate` dep node)
- #68909 (Respect --nocapture in panic=abort test mode)
- #68910 (Add myself to .mailmap)
- #68919 (Remove HashStable impl for ast::Lifetime)
- #68928 (clean up E0276 explanation)
Failed merges:
r? @ghost
@bors
bors merged commit a575495 into rust-lang:masterFeb 7, 2020
@Zoxc
Zoxc deleted the hir-krate branch February 8, 2020 02:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@michaelwoeristermichaelwoeristermichaelwoerister left review comments
@eddybeddybeddyb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@eddybeddyb

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Zoxc@rust-timer@bors@eddyb@michaelwoerister