Uh oh!
There was an error while loading. Please reload this page.
Speed up the inherent impl overlap check - #68911
Merged
Merged
Conversation
jonas-schievink
commented
Feb 7, 2020
ContributorAuthor
@bors try @rust-timer queue |
rust-timer
commented
Feb 7, 2020
Collaborator
Awaiting bors try build completion |
bors
commented
Feb 7, 2020
Collaborator
bors added a commit
that referenced
this pull request
Feb 7, 2020
Speed up the inherent impl overlap check This gives a ~7% improvement in compile times for the stm32f0(x2) crate. Also addresses @eddyb's comment in #68837 (comment).
bors
commented
Feb 7, 2020
Collaborator
☀️ Try build successful - checks-azure |
rust-timer
commented
Feb 7, 2020
Collaborator
Queued a5b4dc5 with parent 442ae7f, future comparison URL. |
eddyb
reviewed
Feb 7, 2020
| // The `Future` trait has only one associted item, `Output`, | ||
| // so check that this is what we see. | ||
| let output_assoc_item = self.tcx.associated_items(future_trait).nth(0).unwrap().def_id; | ||
| let output_assoc_item = self.tcx.associated_items(future_trait)[0].def_id; |
Contributor
There was a problem hiding this comment.
I think this pattern (or worse, looking things up by name) should be replaced with lang items.
ContributorAuthor
There was a problem hiding this comment.
Yeah, definintely. This was a huge pain when working on generators, since the declaration order of the assoc. types is significant. Not something I'll try to fit in this PR though.
eddyb
reviewed
Feb 7, 2020
Uh oh!
There was an error while loading. Please reload this page.
jonas-schievink
commented
Feb 7, 2020
ContributorAuthor
Looks like this made |
bors
commented
Feb 8, 2020
Collaborator
☔ The latest upstream changes (presumably #65232) made this pull request unmergeable. Please resolve the merge conflicts. |
petrochenkov
commented
Feb 8, 2020
Contributor
r=me after rebase |
This reduces the number of `associated_item` queries done here.
Quickly skip impls that do not define any items with the same name
jonas-schievink
commented
Feb 8, 2020
ContributorAuthor
@bors r=petrochenkov |
bors
commented
Feb 8, 2020
Collaborator
📌 Commit 58a9284 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 8, 2020
…=petrochenkov Speed up the inherent impl overlap check This gives a ~7% improvement in compile times for the stm32f0(x2) crate. Also addresses @eddyb's comment in rust-lang#68837 (comment).
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 8, 2020
…=petrochenkov Speed up the inherent impl overlap check This gives a ~7% improvement in compile times for the stm32f0(x2) crate. Also addresses @eddyb's comment in rust-lang#68837 (comment).
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 9, 2020
…=petrochenkov Speed up the inherent impl overlap check This gives a ~7% improvement in compile times for the stm32f0(x2) crate. Also addresses @eddyb's comment in rust-lang#68837 (comment).
bors added a commit
that referenced
this pull request
Feb 9, 2020
Rollup of 5 pull requests Successful merges: - #68738 (Derive Clone + Eq for std::string::FromUtf8Error) - #68742 (implement AsMut<str> for String) - #68881 (rustc_codegen_llvm: always set AlwaysPreserve on all debuginfo variables) - #68911 (Speed up the inherent impl overlap check) - #68913 (Pretty-print generic params and where clauses on associated types) Failed merges: r? @ghost
krishna-veerareddy added a commit
to krishna-veerareddy/rust-clippy
that referenced
this pull request
Feb 9, 2020
bors added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Feb 9, 2020
Rustup to rust-lang/rust#68911 changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives a ~7% improvement in compile times for the stm32f0(x2) crate.
Also addresses @eddyb's comment in #68837 (comment).