Skip to content

Make the SGX arg cleanup implementation a NOP - #69068

Merged
bors merged 1 commit into
rust-lang:masterfrom
Goirad:make-sgx-arg-cleanup-nop
Feb 13, 2020
Merged

Make the SGX arg cleanup implementation a NOP#69068
bors merged 1 commit into
rust-lang:masterfrom
Goirad:make-sgx-arg-cleanup-nop

Conversation

@Goirad

Copy link
Copy Markdown
Contributor

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @KodrAus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 11, 2020
@GoiradGoirad changed the title make the sgx arg cleanup implementation a no opMake the SGX arg cleanup implementation a NOPFeb 11, 2020
@jethrogb

Copy link
Copy Markdown
Contributor

LGTM

@nagisa

Copy link
Copy Markdown
Member

@bors r+ as per the LGTM above.

@bors

bors commented Feb 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1f6fb33 has been approved by nagisa

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2020
@nagisa

Copy link
Copy Markdown
Member

@bors r=jethrogb,nagisa

@bors

bors commented Feb 11, 2020

Copy link
Copy Markdown
Collaborator

💡 This pull request was already approved, no need to approve it again.

@bors

bors commented Feb 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1f6fb33 has been approved by jethrogb,nagisa

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 13, 2020
…jethrogb,nagisa
Make the SGX arg cleanup implementation a NOP
fixesrust-lang#64304
cc @jethrogb
bors added a commit that referenced this pull request Feb 13, 2020
Rollup of 9 pull requests
Successful merges:
- #67642 (Relax bounds on HashMap/HashSet)
- #68848 (Hasten macro parsing)
- #69008 (Properly use parent generics for opaque types)
- #69048 (Suggestion when encountering assoc types from hrtb)
- #69049 (Optimize image sizes)
- #69050 (Micro-optimize the heck out of LEB128 reading and writing.)
- #69068 (Make the SGX arg cleanup implementation a NOP)
- #69082 (When expecting `BoxFuture` and using `async {}`, suggest `Box::pin`)
- #69104 (bootstrap: Configure cmake when building sanitizer runtimes)
Failed merges:
r? @ghost
@bors
bors merged commit 1f6fb33 into rust-lang:masterFeb 13, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SGX's std::env::args function is not thread-safe

6 participants

@Goirad@rust-highfive@jethrogb@nagisa@bors@KodrAus