Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #69172
Merged
Merged
Conversation
Previously, we used a plain `Predicate` to cache results (e.g. successes and failures) in ObligationForest. However, fulfillment depends on the precise `ParamEnv` used, so this is unsound in general. This commit changes the impl of `ForestObligation` for `PendingPredicateObligation` to use `ParamEnvAnd<Predicate>` instead of `Predicate` for the associated type. The associated type and method are renamed from 'predicate' to 'cache_key' to reflect the fact that type is no longer just a predicate.
…reference, r=nikomatsakis Correct inference of primitive operand type behind binary operation Fixesrust-lang#57447. r? @nikomatsakis
…omatsakis Use a `ParamEnvAnd<Predicate>` for caching in `ObligationForest` Previously, we used a plain `Predicate` to cache results (e.g. successes and failures) in ObligationForest. However, fulfillment depends on the precise `ParamEnv` used, so this is unsound in general. This commit changes the impl of `ForestObligation` for `PendingPredicateObligation` to use `ParamEnvAnd<Predicate>` instead of `Predicate` for the associated type. The associated type and method are renamed from 'predicate' to 'cache_key' to reflect the fact that type is no longer just a predicate.
…sper typeck: clarify def_bm adjustments & add tests for or-patterns Clarify the adjustment algorithm for the expected type / default binding-modes when type checking patterns with more documentation and tweaks that make the algorithm more independent of the pattern forms. Also resolve the FIXME noted for or-patterns by deciding that the current implementation is correct, noting the rationale and adding tests for the current implementation. cc rust-lang#54883 r? @oli-obk@varkor
simplify_try: address some of eddyb's comments Addresses only rust-lang#66282 (comment) and rust-lang#66282 (comment). r? @eddyb cc @oli-obk
Fix extra subslice lowering
We are currently ICEing on e.g.
```rust
fn main() {
let [.., b @ ..] = [1, 2];
b;
}
```
This happens because `b @ ..` registers a binding such that `b;` is OK, but then we forget to lower that binding in `rustc_ast_lowering`.
Fixesrust-lang#69103.
r? @davidtwco…ochenkov Follow-up to rust-lang#68848 This PR contains some late changes to rust-lang#68848 that somehow didn't get included when that PR was merged in a roll-up. r? @petrochenkov
…k, r=Dylan-DPC Update pulldown-cmark dependency r? @kinnison cc @ollie27 Reopening of rust-lang#65894.
JohnTitor
commented
Feb 14, 2020
MemberAuthor
@bors r+ p=7 rollup=never |
bors
commented
Feb 14, 2020
Collaborator
📌 Commit a6ff1db has been approved by |
bors
commented
Feb 14, 2020
Collaborator
bors added a commit
that referenced
this pull request
Feb 14, 2020
Rollup of 7 pull requests Successful merges: - #68129 (Correct inference of primitive operand type behind binary operation) - #68475 (Use a `ParamEnvAnd<Predicate>` for caching in `ObligationForest`) - #68856 (typeck: clarify def_bm adjustments & add tests for or-patterns) - #69051 (simplify_try: address some of eddyb's comments) - #69128 (Fix extra subslice lowering) - #69150 (Follow-up to #68848) - #69164 (Update pulldown-cmark dependency) Failed merges: r? @ghost
bors
commented
Feb 15, 2020
Collaborator
☀️ Test successful - checks-azure |
This was referenced Feb 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
ParamEnvAnd<Predicate>for caching inObligationForest#68475 (Use aParamEnvAnd<Predicate>for caching inObligationForest)Failed merges:
r? @ghost