Skip to content

Add documentation for the -Zself-profile flag - #69220

Merged
bors merged 2 commits into
rust-lang:masterfrom
wesleywiser:doc_self_profile_unstable_book
Feb 25, 2020
Merged

Add documentation for the -Zself-profile flag#69220
bors merged 2 commits into
rust-lang:masterfrom
wesleywiser:doc_self_profile_unstable_book

Conversation

@wesleywiser

@wesleywiserwesleywiser commented Feb 17, 2020

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

rust-highfive commented Feb 17, 2020

Copy link
Copy Markdown
Contributor

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2020
@wesleywiserwesleywiser mentioned this pull request Feb 17, 2020
Merged
@andjo403

andjo403 commented Feb 17, 2020

Copy link
Copy Markdown
Contributor

nice work. shall there maybe also be some short description of the -Zself_profile_events?

@wesleywiser
wesleywiserforce-pushed the doc_self_profile_unstable_book branch from 9653640 to 58ec5d2CompareFebruary 17, 2020 11:42
@wesleywiser

wesleywiser commented Feb 17, 2020

Copy link
Copy Markdown
MemberAuthor

@andjo403 Yeah, that's a good idea!

@andjo403

andjo403 commented Feb 17, 2020

Copy link
Copy Markdown
Contributor

this looks amazing

@wesleywiser

wesleywiser commented Feb 17, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks!

@wesleywiser

wesleywiser commented Feb 18, 2020

Copy link
Copy Markdown
MemberAuthor

r? @nikomatsakis

@wesleywiser

wesleywiser commented Feb 20, 2020

Copy link
Copy Markdown
MemberAuthor

cc @michaelwoerister

michaelwoerister
michaelwoerister reviewed Feb 20, 2020
View reviewed changes
Comment threadsrc/doc/unstable-book/src/compiler-flags/self-profile-events.md Outdated
michaelwoerister
michaelwoerister reviewed Feb 20, 2020
View reviewed changes
Comment threadsrc/doc/unstable-book/src/compiler-flags/self-profile-events.md Outdated
michaelwoerister
michaelwoerister reviewed Feb 20, 2020
View reviewed changes
Comment threadsrc/doc/unstable-book/src/compiler-flags/self-profile-events.md Outdated
michaelwoerister
michaelwoerister reviewed Feb 20, 2020
View reviewed changes
Comment threadsrc/doc/unstable-book/src/compiler-flags/self-profile-events.md Outdated

@michaelwoeristermichaelwoeristerFeb 20, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

off-topic: we should measure if enabling this by default adds noticeable overhead.

michaelwoerister
michaelwoerister reviewed Feb 20, 2020
View reviewed changes
Comment threadsrc/doc/unstable-book/src/compiler-flags/self-profile-events.md Outdated
@michaelwoerister

michaelwoerister commented Feb 20, 2020

Copy link
Copy Markdown
Member

Looks great! I left a few minor suggestions.

@wesleywiser
wesleywiserforce-pushed the doc_self_profile_unstable_book branch from 58ec5d2 to 5b7e6c0CompareFebruary 21, 2020 02:32
@wesleywiser

wesleywiser commented Feb 21, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks @michaelwoerister! I applied your suggestions.

nikomatsakis
nikomatsakis approved these changes Feb 24, 2020
View reviewed changes

@nikomatsakisnikomatsakis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful, thanks @wesleywiser

@nikomatsakis

nikomatsakis commented Feb 24, 2020

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Feb 24, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 5b7e6c0 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2020
@nikomatsakis

nikomatsakis commented Feb 24, 2020

Copy link
Copy Markdown
Contributor

@bors rollup=always

Just edits documentation, low risk.

@wesleywiser

wesleywiser commented Feb 24, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks @nikomatsakis! Once this lands, I'll update the blog post to link to these docs, update the post date and then we'll be ready to post it.

@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Feb 24, 2020
Merged
bors added a commit that referenced this pull request Feb 25, 2020
@bors
Auto merge of#69440- Dylan-DPC:rollup-hj4bo9l, r=Dylan-DPC
e3a2779
Rollup of 6 pull requests
Successful merges:
- #69220 (Add documentation for the `-Zself-profile` flag)
- #69391 (Add rustdoc aliases to `ptr::copy` and `ptr::copy_nonoverlapping`)
- #69427 (Cleanup e0368 e0369)
- #69433 (don't explicitly compare against true or false)
- #69435 (Replace uses of Cell::get + Cell::set with Cell::replace.)
- #69437 (no more codegen for miri_start_panic)
Failed merges:
r? @ghost
@bors
bors merged commit d916578 into rust-lang:masterFeb 25, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis approved these changes
+1 more reviewer
@michaelwoeristermichaelwoeristermichaelwoerister left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wesleywiser@rust-highfive@andjo403@michaelwoerister@nikomatsakis@bors@QuietMisdreavus