Skip to content

Rollup of 8 pull requests - #69253

Closed
JohnTitor wants to merge 16 commits into
rust-lang:masterfrom
JohnTitor:rollup-4asn252
Closed

Rollup of 8 pull requests#69253
JohnTitor wants to merge 16 commits into
rust-lang:masterfrom
JohnTitor:rollup-4asn252

Conversation

@JohnTitor

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost

ollie27and others added 16 commits January 28, 2020 12:39
The main improvement is to make `last` no longer recursive.
Rather than a boolean `--enable-cflags` etc., these options should
reflect that they are for LLVM, and that they need a value. You would
now use `./configure --llvm-cflags="..."`.
This helps us have enough disk space for our builders to be able to complete
successfully. For now, the choices are ad-hoc and 'definitely not needed'. This
should never fail the build, as everything our build needs should be inside
Docker.
…ow554
recursion_limit parsing handles overflows
This PR adds overflow handling to `#![recursion_limit]` attribute parsing. If parsing the given value results in an `IntErrorKind::Overflow`, then the recursion_limit is set to `usize::max_value()`.
closesrust-lang#67265
Simplify `Skip::nth` and `Skip::last` implementations
The main improvement is to make `last` no longer recursive.
Do not ICE when encountering `yield` inside `async` block
Fixrust-lang#67158.
configure: set LLVM flags with a value
Rather than a boolean `--enable-cflags` etc., these options should
reflect that they are for LLVM, and that they need a value. You would
now use `./configure --llvm-cflags="..."`.
…ts, r=sfackler
Stabilize {f32, f64}::{LOG2_10, LOG10_2}
Following the decision to stabilize `LOG2_10` and `LOG10_2` in rust-lang#50540 (comment).
Closesrust-lang#50540.
r? @sfackler
Clean out unused directories for extra disk space
This cleans out some of the unused (but large) directories on our linux builders to hopefully allow them to complete without running out of disk space.
@JohnTitor

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=101

@bors

bors commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 125b328 has been approved by JohnTitor

@bors

bors commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 18, 2020
@bors

bors commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 125b328 with merge ef1765e...

bors added a commit that referenced this pull request Feb 18, 2020
Rollup of 8 pull requests
Successful merges:
- #67272 (recursion_limit parsing handles overflows)
- #68597 (Simplify `Skip::nth` and `Skip::last` implementations)
- #68767 (macOS: avoid calling pthread_self() twice)
- #69175 (Do not ICE when encountering `yield` inside `async` block)
- #69223 (Ignore GDB versions with broken str printing.)
- #69244 (configure: set LLVM flags with a value)
- #69249 (Stabilize {f32, f64}::{LOG2_10, LOG10_2})
- #69252 (Clean out unused directories for extra disk space)
Failed merges:
r? @ghost
@JohnTitorJohnTitor added the rollup A PR which is a rollup label Feb 18, 2020
@bors

bors commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2020
@JohnTitor

Copy link
Copy Markdown
MemberAuthor

"Show the current environment" on Windows takes quite long time, let's
@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2020
@bors

bors commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 125b328 with merge cb01d05fa8a87a1e2ee7bc2b3e6d0934d3b7c38a...

@bors

bors commented Feb 18, 2020

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 18, 2020
@JohnTitor
JohnTitor deleted the rollup-4asn252 branch February 18, 2020 10:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollupS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@JohnTitor@bors@ollie27@kubo39@LeSeulArtichaut@spunit262@estebank@cuviper@Mark-Simulacrum