Uh oh!
There was an error while loading. Please reload this page.
Inline some encoding and decoding methods. - #69281
Conversation
This is a small performance win.
nnethercote
commented
Feb 19, 2020
Local A small but clear win, not bad for such a simple change. |
nnethercote
commented
Feb 20, 2020
@bors try @rust-timer queue |
rust-timer
commented
Feb 20, 2020
Awaiting bors try build completion |
nnethercote
commented
Feb 20, 2020
@bors rollup=never, because it affects performance. |
bors
commented
Feb 20, 2020
⌛ Trying commit 139c3ca with merge c503f7d1956eee59812f2d542b674e2c7e2777e7... |
Centril
commented
Feb 20, 2020
r=me with perf improved |
bors
commented
Feb 20, 2020
☀️ Try build successful - checks-azure |
rust-timer
commented
Feb 20, 2020
Queued c503f7d1956eee59812f2d542b674e2c7e2777e7 with parent 7760cd0, future comparison URL. |
rust-timer
commented
Feb 20, 2020
Finished benchmarking try commit c503f7d1956eee59812f2d542b674e2c7e2777e7, comparison URL. |
nnethercote
commented
Feb 21, 2020
It's a miniscule win, but a win nonetheless. @bors r=Centril |
bors
commented
Feb 21, 2020
📌 Commit 139c3ca has been approved by |
bors
commented
Feb 21, 2020
bors
commented
Feb 21, 2020
☀️ Test successful - checks-azure |
| macro_rules! encoder_methods { | ||
| ($($name:ident($ty:ty);)*) => { | ||
| #[inline] | ||
| $(fn $name(&mut self, value: $ty) -> Result<(), Self::Error> { |
There was a problem hiding this comment.
The #[inline] here is only applied to the first method. Always putting $( on its own line would have avoided this. cc rust-lang/rustfmt#8 cc #71208
This is a small performance win.
r? @Centril