Skip to content

Do not ping the infrastructure team on toolstate changes - #69336

Merged
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:no-infra-toolstate
Feb 23, 2020
Merged

Do not ping the infrastructure team on toolstate changes#69336
bors merged 1 commit into
rust-lang:masterfrom
Mark-Simulacrum:no-infra-toolstate

Conversation

@Mark-Simulacrum

@Mark-SimulacrumMark-Simulacrum commented Feb 21, 2020•
edited
Loading

Copy link
Copy Markdown
Member

To my knowledge, there is essentially never any particular action that the infra team needs to take on these pings, and they are currently relatively annoying.

cc rust-lang/infra -- does anyone want these notifications?

@Mark-Simulacrum
Do not ping the infrastructure team on toolstate changes
e7ee42b
To my knowledge, there is essentially never any particular action that the
infra team needs to take on these pings, and they are currently relatively
annoying.
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 21, 2020
@Dylan-DPC-zz

Dylan-DPC-zz commented Feb 21, 2020

Copy link
Copy Markdown

@bors r+

@bors

bors commented Feb 21, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit e7ee42b has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 21, 2020
@Mark-Simulacrum

Mark-Simulacrum commented Feb 21, 2020

Copy link
Copy Markdown
MemberAuthor

@bors r-

I specifically want to give some time for infra to chime in.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 21, 2020
@bjorn3

bjorn3 commented Feb 21, 2020

Copy link
Copy Markdown
Member

cc rust-lang/infra -- does anyone want these notifications?

You seem to have omitted the @.

@kennytmkennytm added S-waiting-on-team T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 21, 2020
@kennytm

kennytm commented Feb 21, 2020

Copy link
Copy Markdown
Member

Perhaps:

@rfcbot fcp merge

@rfcbot

rfcbot commented Feb 21, 2020•
edited by shepmaster
Loading

Copy link
Copy Markdown

Team member @kennytm has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbotrfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Feb 21, 2020
@Mark-Simulacrum

Mark-Simulacrum commented Feb 21, 2020

Copy link
Copy Markdown
MemberAuthor

I intentionally edited to remove the mention because bors includes the PR description in commits, and I didn't want to ping everyone lots of times needlessly.

Thanks for kicking off FCP, that's a good idea!

@shepmaster

shepmaster commented Feb 21, 2020

Copy link
Copy Markdown
Member

As my own personal thing, I sometimes like those notifications because it means something interesting was merged. Other times it's not. Too bad there's no "would be magically interesting" filter 😉

@rfcbotrfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Feb 21, 2020
@rfcbot

rfcbot commented Feb 21, 2020

Copy link
Copy Markdown

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbotrfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Feb 21, 2020
@Mark-Simulacrum

Mark-Simulacrum commented Feb 23, 2020

Copy link
Copy Markdown
MemberAuthor

@bors r=Dylan-DPC I guess, no need to wait for FCP I think. We can always revert, and I'm getting sufficiently annoyed at this filling up my triagebot notifications with noise :)

@bors

bors commented Feb 23, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit e7ee42b has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team labels Feb 23, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 23, 2020
@Dylan-DPC
Rollup merge ofrust-lang#69336- Mark-Simulacrum:no-infra-toolstate,…
b760994
… r=Dylan-DPC
Do not ping the infrastructure team on toolstate changes
To my knowledge, there is essentially never any particular action that the infra team needs to take on these pings, and they are currently relatively annoying.
cc rust-lang/infra -- does anyone *want* these notifications?
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Feb 23, 2020
Merged
@bors

bors commented Feb 23, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e7ee42b with merge 9c230f3...

@bors

bors commented Feb 23, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing 9c230f3 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Feb 23, 2020
@bors
bors merged commit 9c230f3 into rust-lang:masterFeb 23, 2020
bors added a commit that referenced this pull request Feb 23, 2020
@bors
Auto merge of#69393- Dylan-DPC:rollup-rxbd1zg, r=Dylan-DPC
6d0e58b
Rollup of 5 pull requests
Successful merges:
- #69336 (Do not ping the infrastructure team on toolstate changes)
- #69351 (Improve external MinGW detection)
- #69361 (parse: allow `type Foo: Ord` syntactically)
- #69375 (Rename CodeMap to SourceMap follow up)
- #69376 (parser: Cleanup `Parser::bump_with` and its uses)
Failed merges:
r? @ghost
@rfcbotrfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Mar 2, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emilyalbiniemilyalbini

Labels

disposition-mergeThis issue / PR is in PFCP or FCP with a disposition to merge it.finished-final-comment-periodThe final comment period is finished for this PR / Issue.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Mark-Simulacrum@Dylan-DPC-zz@bors@bjorn3@kennytm@rfcbot@shepmaster@emilyalbini@rust-highfive