Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #69374
Merged
Merged
Conversation
`char::is_ascii` is already a stable `const fn`, so there is no reason for `u8::is_ascii` to be unstable.
This bug was fixed by rust-lang#67501. Closesrust-lang#69312
A `Duration` is created from a second and nanoseconds variable. The documentation says: "This constructor will panic if the carry from the nanoseconds overflows the seconds counter". This was, however, not tested in the tests. I doubt the behavior will ever regress, but it is usually a good idea to test all documented behavior.
Bless tests
…=sfackler Make `u8::is_ascii` a stable `const fn` `char::is_ascii` was already stabilized as `const fn` in rust-lang#55278, so there is no reason for `u8::is_ascii` to go through an unstable period. cc @rust-lang/libs
Add test for rust-lang#69312 This bug was fixed by rust-lang#67501. Closesrust-lang#69312
…nations, r=Dylan-DPC Clean up E0323, E0324, E0325 and E0326 explanations r? @Dylan-DPC
Wrong error message for move_ref_pattern
The current error message states that move occurs *because of `Copy`*:
```Rust
"move occurs because `{}` has type `{}` which does implement the `Copy` trait."
```
I found this randomly when surfing through the sources. This means, I don't have any context and might be completely wrong.
r? @Centril…=Dylan-DPC MIR is not an experiment anymore At least I hope is not 😝 r? @oli-obk
…test, r=Centril Test `Duration::new` panics on overflow A `Duration` is created from a second and nanoseconds variable. The documentation says: "This constructor will panic if the carry from the nanoseconds overflows the seconds counter". This was, however, not tested in the tests. I doubt the behavior will ever regress, but it is usually a good idea to test all documented behavior.
move const_eval.rs into the module folder This groups the file together with the other `const_eval` files in editors, diff views, etc. r? @oli-obk
Dylan-DPC-zz
commented
Feb 22, 2020
Author
@bors r+ p=7 rollup=never |
bors
commented
Feb 22, 2020
Collaborator
📌 Commit e5fb129 has been approved by |
bors
commented
Feb 22, 2020
Collaborator
bors
commented
Feb 22, 2020
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
u8::is_asciia stableconst fn#68984 (Makeu8::is_asciia stableconst fn)Duration::newpanics on overflow #69354 (TestDuration::newpanics on overflow)Failed merges:
r? @ghost