Uh oh!
There was an error while loading. Please reload this page.
--explain disambiguates no long description and invalid error codes - #69442
Conversation
rust-highfive
commented
Feb 24, 2020
Some changes occurred in diagnostic error codes |
rust-highfive
commented
Feb 24, 2020
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Centril
commented
Feb 24, 2020
r? @Mark-Simulacrum cc @rust-lang/wg-diagnostics |
rust-highfive
commented
Feb 24, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
This is looking great!
I've added some comments -- I didn't have time to go back through a second time to make sure they're all consistent, but the latter comments are the "more correct" ones as I gained a better understanding of the code myself.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
GuillaumeGomez
left a comment
There was a problem hiding this comment.
Good idea, thanks for doing it!
--explain disamiguates no long description and invalid error codes--explain disambiguates no long description and invalid error codesUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Mark-Simulacrum
commented
Feb 27, 2020
Please also squash all the commits down into one in your next push, and I think this'll be ready to go! |
Mark-Simulacrum
commented
Feb 28, 2020
@bors r+ |
bors
commented
Feb 28, 2020
📌 Commit 89cadeddb17ce788401f4f854158e94f755da0ff has been approved by |
bors
commented
Feb 28, 2020
☔ The latest upstream changes (presumably #69555) made this pull request unmergeable. Please resolve the merge conflicts. |
estebank
commented
Feb 28, 2020
@jakevossen5 you will need to rebase on top of a recent master. |
jakevossen5
commented
Feb 29, 2020
@estebank should be good now! |
Mark-Simulacrum
commented
Feb 29, 2020
Commits need to be squashed into one here it looks like but otherwise this is good to go. |
jakevossen5
commented
Feb 29, 2020
@Mark-Simulacrum should be good now, thank you! |
Mark-Simulacrum
commented
Feb 29, 2020
@bors r+ Thanks! |
bors
commented
Feb 29, 2020
📌 Commit 5f3ffee has been approved by |
bors
commented
Mar 2, 2020
bors
commented
Mar 2, 2020
☀️ Test successful - checks-azure |
Closes#44710
First code contribution here, so feedback is very much appreciated!
cc @zackmdavis
cc @Mark-Simulacrum