Skip to content

rustc::middle::trans::reachable: remove some unneeded code - #6945

Closed
Blei wants to merge 2 commits into
rust-lang:incomingfrom
Blei:remove-export-all
Closed

rustc::middle::trans::reachable: remove some unneeded code#6945
Blei wants to merge 2 commits into
rust-lang:incomingfrom
Blei:remove-export-all

Conversation

@Blei

@BleiBlei commented Jun 5, 2013

Copy link
Copy Markdown
Contributor

This was a remnant from the export list era.

@Blei

Blei commented Jun 6, 2013

Copy link
Copy Markdown
ContributorAuthor

Pushed a fix (hopefully).

@Blei

Blei commented Jun 7, 2013

Copy link
Copy Markdown
ContributorAuthor

This needed a rebase, which I've pushed now.

This was a remnant from the export list era.
@Blei

Blei commented Jun 8, 2013

Copy link
Copy Markdown
ContributorAuthor

Pushed a rebase and fixed the last failing test.

@Blei

Blei commented Jun 10, 2013

Copy link
Copy Markdown
ContributorAuthor

Hmm, the failure doesn't look related. In fact, it's the same one as in #7035, where it also doesn't look related.

@Blei

Blei commented Jun 10, 2013

Copy link
Copy Markdown
ContributorAuthor

In fact, when looking at the code around the triggered assertion, it looks like this is caused by running the rustpkg tests in parallel and tripping over LLVM global data. Hopefully #7040 clears this up.

@Blei

Blei commented Jun 10, 2013

Copy link
Copy Markdown
ContributorAuthor

Looking into this a little bit more, it looks like LLVM will have to be recompiled with --enable-threads, so this depends on #6713.

@graydongraydon closed this Jun 13, 2013
@BleiBlei mentioned this pull request Jun 14, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Mar 25, 2021
…nDefault, r=Manishearth
Fix suggestion with generics for `field_reassign_with_default` lint
Fix bad suggestion where `::` is missing after type if generics are involved
Fixesrust-lang#6944
changelog: none
U007D pushed a commit to U007D/rust-mos that referenced this pull request Aug 21, 2026
7367: Bump chalk r=lnicola a=lnicola
Fixesrust-lang#6945Fixesrust-lang#6812
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Blei@bors@graydon