Skip to content

Rollup of 4 pull requests - #69499

Closed
Dylan-DPC-zz wants to merge 8 commits into
rust-lang:masterfrom
Dylan-DPC-zz:rollup-0re6wlf
Closed

Rollup of 4 pull requests#69499
Dylan-DPC-zz wants to merge 8 commits into
rust-lang:masterfrom
Dylan-DPC-zz:rollup-0re6wlf

Conversation

@Dylan-DPC-zz

Copy link
Copy Markdown

Successful merges:

Failed merges:

r? @ghost

petrochenkovand others added 8 commits February 24, 2020 21:46
resolve: `lifetimes.rs` -> `late/lifetimes.rs`
Lifetime resolution should ideally be merged into the late resolution pass, at least for named lifetimes.
Let's move it closer to it for a start.
@Dylan-DPC-zz

Copy link
Copy Markdown
Author

@bors r+ rollup=never p=4

@bors

bors commented Feb 26, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 7f11fd0 has been approved by Dylan-DPC

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 26, 2020
@Dylan-DPC-zzDylan-DPC-zz added the rollup A PR which is a rollup label Feb 26, 2020
@bors

bors commented Feb 27, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7f11fd0 with merge 36156c9...

bors added a commit that referenced this pull request Feb 27, 2020
Rollup of 4 pull requests
Successful merges:
- #69439 (resolve: `lifetimes.rs` -> `late/lifetimes.rs`)
- #69473 (update llvm to silence gcc 9 warnings)
- #69479 (clarify operator precedence)
- #69480 (Clean up E0373 explanation)
Failed merges:
- #69481 (use char instead of &str for single char patterns)
- #69496 (use find(x) instead of filter(x).next())
r? @ghost
@bors

bors commented Feb 27, 2020

Copy link
Copy Markdown
Collaborator

💥 Test timed out

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2020
@JohnTitor

Copy link
Copy Markdown
Member

Closing in favor of new rollup.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollupS-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@Dylan-DPC-zz@bors@JohnTitor@petrochenkov@contrun@matthiaskrgr@GuillaumeGomez@Dylan-DPC