Uh oh!
There was an error while loading. Please reload this page.
Remove unneeded calls to format!() - #69541
Conversation
rust-highfive
commented
Feb 28, 2020
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Feb 28, 2020
@bors r+ rollup Out of interest, how were these found? Clippy? |
bors
commented
Feb 28, 2020
📌 Commit c1de0b1 has been approved by |
dotdash
commented
Feb 28, 2020
I wish it was ;-) Some time in 2018 I added a hack to format!() to find unnecessary calls, but forgot to submit the results. Recently I rediscovered that branch, but rebasing failed, and lots of cases had already been fixed. Since the old approach was slow, I resorted to some creative use of ripgrep that left me with a few dozen places I manually checked when I was stumped by a completely unrelated problem and needed some brainless activity to clear my mind. |
Rollup of 10 pull requests Successful merges: - #68989 (Update RELEASES.md for 1.42.0) - #69340 (instantiate_value_path: on `SelfCtor`, avoid unconstrained tyvars) - #69384 (parser: `token` -> `normalized_token`, `nonnormalized_token` -> `token`) - #69452 (typeck: use `Pattern` obligation cause more for better diagnostics) - #69481 (use char instead of &str for single char patterns) - #69522 (error_derive_forbidden_on_non_adt: be more graceful) - #69538 (Stabilize `boxed_slice_try_from`) - #69539 (late resolve, visit_fn: bail early if there's no body.) - #69541 (Remove unneeded calls to format!()) - #69547 (remove redundant clones, references to operands, explicit boolean comparisons and filter(x).next() calls.) Failed merges: r? @ghost
use .to_string() instead of format!() macro to create strings handles what is left after rust-lang#69541
No description provided.