Uh oh!
There was an error while loading. Please reload this page.
check_binding_alt_eq_ty: improve precision wrt. if let - #69599
Merged
Conversation
Centril
commented
Mar 6, 2020
ContributorAuthor
r? @davidtwco |
davidtwco
approved these changes
Mar 7, 2020
davidtwco
commented
Mar 7, 2020
Member
@bors r+ |
bors
commented
Mar 7, 2020
Collaborator
📌 Commit 2746e12 has been approved by |
bors
commented
Mar 7, 2020
Collaborator
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
Centril added a commit
to Centril/rust
that referenced
this pull request
Mar 8, 2020
…idtwco check_binding_alt_eq_ty: improve precision wrt. `if let` Follow up to rust-lang#69452 -- this tweaks the `check_binding_alt_eq_ty` logic wrt. wording so that `if let` doesn't include "in this arm" (because there can only ever be one arm). r? @estebank
bors added a commit
that referenced
this pull request
Mar 8, 2020
Rollup of 8 pull requests Successful merges: - #69422 (Remove use of `unwrap()` from save-analysis) - #69548 (Turn trailing tokens in `assert!()` into hard errors) - #69561 (Clean up unstable book) - #69599 (check_binding_alt_eq_ty: improve precision wrt. `if let`) - #69641 (Update books) - #69776 (Fix & test leak of some BTreeMap nodes on panic during `into_iter`) - #69805 (resolve: Modernize some naming) - #69810 (test(bindings_after_at): add dynamic drop tests for bindings_after_at) Failed merges: r? @ghost
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #69452 -- this tweaks the
check_binding_alt_eq_tylogic wrt. wording so thatif letdoesn't include "in this arm" (because there can only ever be one arm).r? @estebank