Uh oh!
There was an error while loading. Please reload this page.
cleanup more iterator usages (and other things) - #69650
Merged
Merged
Conversation
matthiaskrgr
commented
Mar 3, 2020
Member
- Improve weird formatting by moving comment inside else-code block.
- Use .any(x) instead of .find(x).is_some() on iterators.
- Use .nth(x) instead of .skip(x).next() on iterators.
- Simplify conditions like x + 1 <= y to x < y
- Use let instead of match to get value of enum with single variant.
rust-highfive
commented
Mar 3, 2020
Contributor
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
varkor
commented
Mar 3, 2020
Contributor
@bors r+ rollup |
bors
commented
Mar 3, 2020
Collaborator
📌 Commit 1018385 has been approved by |
bors added a commit
that referenced
this pull request
Mar 3, 2020
Rollup of 6 pull requests Successful merges: - #69565 (miri engine: turn some debug_assert into assert) - #69621 (use question mark operator in a few places.) - #69650 (cleanup more iterator usages (and other things)) - #69653 (use conditions directly) - #69665 (Invoke OptimizerLastEPCallbacks in PreLinkThinLTO) - #69670 (Add explanation for E0379) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.