Skip to content

Change DIBuilderCreateEnumerator signature to match LLVM 9 - #69734

Merged
bors merged 3 commits into
rust-lang:masterfrom
tmiasko:di-enumerator
Mar 9, 2020
Merged

Change DIBuilderCreateEnumerator signature to match LLVM 9#69734
bors merged 3 commits into
rust-lang:masterfrom
tmiasko:di-enumerator

Conversation

@tmiasko

@tmiaskotmiasko commented Mar 5, 2020

Copy link
Copy Markdown
Contributor
  • Change DIBuilderCreateEnumerator signature to match LLVM 9 C API.
  • Use provided is unsigned flag when emitting enumerators.

@rust-highfive

rust-highfive commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ecstatic-morse (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2020
ecstatic-morse
ecstatic-morse suggested changes Mar 5, 2020
View reviewed changes

@ecstatic-morseecstatic-morse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions about ownership need to be resolved before this is merged. Also left a nit about using as casts for discriminants.

Comment threadsrc/librustc_codegen_llvm/debuginfo/metadata.rs Outdated
Comment threadsrc/librustc_codegen_llvm/debuginfo/metadata.rs Outdated
Comment threadsrc/librustc_codegen_llvm/debuginfo/metadata.rs Outdated
@ecstatic-morse

ecstatic-morse commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Thanks @tmiasko! LGTM, although I'm gonna defer to someone who works on this code, since I don't quite understand why this worked before if we were using the wrong signature.

r? @nagisa

@tmiasko

tmiasko commented Mar 5, 2020

Copy link
Copy Markdown
ContributorAuthor

Oh sorry, I didn't made it clear in PR description. The PR prepares for migration
to the C API that is available since LLVM 9, without actually mgirating it yet, sice
we support older versions of LLVM.

Thus the code continues to use own wrapper LLVMRustDIBuilderCreateEnumerator rather than
official one LLVMDIBuilderCreateEnumerator, but now they have exactly the same type
signature and arguments.

@ecstatic-morse

ecstatic-morse commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Ah, I see now.

r? @ecstatic-morse
@bors r+ rollup

@bors

bors commented Mar 5, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 30650f8 has been approved by ecstatic-morse

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2020
@ecstatic-morse

ecstatic-morse commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Note to self: llvm::StringRef explicitly does not require the string to be null-terminated. It does, however, have a const char* constructor for null-terminated strings, which is what we were using prior to this PR.

@CentrilCentril mentioned this pull request Mar 8, 2020
Merged
bors added a commit that referenced this pull request Mar 8, 2020
@bors
Auto merge of#69833- Centril:rollup-mh74yue, r=Centril
2cb0b85
Rollup of 7 pull requests
Successful merges:
- #69120 (Don't give invalid suggestion on desugared span.)
- #69326 (mir-interpret: add method to read wide strings from Memory)
- #69608 (Expose target libdir information via print command)
- #69734 (Change DIBuilderCreateEnumerator signature to match LLVM 9)
- #69800 (Compile address sanitizer test with debuginfo)
- #69807 (Cleanup E0391 explanation)
- #69820 (clean up E0392 explanation)
Failed merges:
r? @ghost
@bors
bors merged commit e2617a9 into rust-lang:masterMar 9, 2020
@tmiasko
tmiasko deleted the di-enumerator branch March 9, 2020 00:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@ecstatic-morseecstatic-morseecstatic-morse requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ecstatic-morseecstatic-morse

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tmiasko@rust-highfive@ecstatic-morse@bors@nagisa