Skip to content

resolve: Print import chains on privacy errors - #69811

Merged
bors merged 3 commits into
rust-lang:masterfrom
petrochenkov:privdiag2
Mar 17, 2020
Merged

resolve: Print import chains on privacy errors#69811
bors merged 3 commits into
rust-lang:masterfrom
petrochenkov:privdiag2

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

A part of #67951 that doesn't require hacks.
r? @estebank

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2020
@estebank

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 9, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 059e825 has been approved by estebank

@bors

bors commented Mar 9, 2020

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 10, 2020
resolve: Print import chains on privacy errors
A part of rust-lang#67951 that doesn't require hacks.
r? @estebank
@CentrilCentril mentioned this pull request Mar 10, 2020
@Centril

Copy link
Copy Markdown
Contributor

Failed in #69883, due to your own renames 😂, @bors r-
(You'll want to rebase.)

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2020
@petrochenkov

Copy link
Copy Markdown
ContributorAuthor

@bors r=estebank

@bors

bors commented Mar 10, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 6514bd560573d701a4bb044620c5f2189beccd5a has been approved by estebank

@bors

bors commented Mar 10, 2020

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2020
@petrochenkov

Copy link
Copy Markdown
ContributorAuthor

@bors r=estebank
(The "consider importing it directly" label is added to notes on imports as well.)

@bors

bors commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f4083c6 has been approved by estebank

Centril added a commit to Centril/rust that referenced this pull request Mar 16, 2020
resolve: Print import chains on privacy errors
A part of rust-lang#67951 that doesn't require hacks.
r? @estebank
@CentrilCentril mentioned this pull request Mar 16, 2020
@CentrilCentril mentioned this pull request Mar 17, 2020
bors added a commit that referenced this pull request Mar 17, 2020
Rollup of 7 pull requests
Successful merges:
- #69811 (resolve: Print import chains on privacy errors)
- #69870 (expand: Implement something similar to `#[cfg(accessible(path))]`)
- #69881 (VariantSizeDifferences: bail on SizeOverflow)
- #70000 (resolve: Fix regression in resolution of raw keywords in paths)
- #70029 (Bump the bootstrap compiler)
- #70046 (Use sublice patterns to avoid computing the len)
- #70049 (Fiddle `ParamEnv` through to a place that used to use `ParamEnv::empty` in a buggy manner)
Failed merges:
r? @ghost
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 17, 2020
resolve: Print import chains on privacy errors
A part of rust-lang#67951 that doesn't require hacks.
r? @estebank
@bors
bors merged commit b691145 into rust-lang:masterMar 17, 2020
@petrochenkov
petrochenkov deleted the privdiag2 branch February 22, 2025 18:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov@estebank@bors@Centril@rust-highfive