Skip to content

Add more regression tests - #69842

Merged
bors merged 7 commits into
rust-lang:masterfrom
JohnTitor:more-tests
Mar 9, 2020
Merged

Add more regression tests#69842
bors merged 7 commits into
rust-lang:masterfrom
JohnTitor:more-tests

Conversation

@JohnTitor

@JohnTitorJohnTitor commented Mar 9, 2020

Copy link
Copy Markdown
Member

Closes#54239
Closes#57200
Closes#57201
Closes#60473
Closes#64620
Closes#67166

r? @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 9, 2020
Centril
Centril reviewed Mar 9, 2020
View reviewed changes

@CentrilCentril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with FIXMEs added.

Comment threadsrc/test/ui/impl-trait/issue-57200.rs
Comment threadsrc/test/ui/impl-trait/issue-57201.rs
Comment threadsrc/test/ui/impl-trait/issue-60473.stderr
@@ -0,0 +1,11 @@
error[E0720]: opaque type expands to a recursive type

@CentrilCentrilMar 9, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look correct to me, please leave a FIXME to revaluate.
Also, cc @matthewjasper re. ^---. Is this is due to some hack?

Comment threadsrc/test/ui/impl-trait/issue-67166.stderr
@CentrilCentril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2020
@JohnTitor

JohnTitor commented Mar 9, 2020

Copy link
Copy Markdown
MemberAuthor

Added FIXMEs.
@bors r=Centril

@bors

bors commented Mar 9, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit ef98ec0 has been approved by Centril

@bors

bors commented Mar 9, 2020

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 9, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 9, 2020
@Centril
Rollup merge ofrust-lang#69842- JohnTitor:more-tests, r=Centril
77da717
Add more regression tests
Closesrust-lang#54239Closesrust-lang#57200Closesrust-lang#57201Closesrust-lang#60473Closesrust-lang#64620Closesrust-lang#67166
r? @Centril
@CentrilCentril mentioned this pull request Mar 9, 2020
Closed
@CentrilCentril mentioned this pull request Mar 9, 2020
Merged
bors added a commit that referenced this pull request Mar 9, 2020
@bors
Auto merge of#69851- Centril:rollup-iivxvah, r=Centril
3dbade6
Rollup of 6 pull requests
Successful merges:
- #69201 (Permit attributes on 'if' expressions)
- #69685 (unix: Don't override existing SIGSEGV/BUS handlers)
- #69762 (Ensure that validity only raises validity errors)
- #69779 (librustc_codegen_llvm: Use slices in preference to 0-terminated strings)
- #69801 (rustc_parse: Remove `Parser::normalized(_prev)_token`)
- #69842 (Add more regression tests)
Failed merges:
r? @ghost
@bors
bors merged commit 7e903f8 into rust-lang:masterMar 9, 2020
@JohnTitor
JohnTitor deleted the more-tests branch March 9, 2020 15:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CentrilCentrilCentril left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@CentrilCentril

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

4 participants

@JohnTitor@bors@Centril@rust-highfive