Skip to content

miri engine: turn error sanity checks into assertions - #69880

Merged
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:miri-assert-error-sanity
Mar 23, 2020
Merged

miri engine: turn error sanity checks into assertions#69880
bors merged 1 commit into
rust-lang:masterfrom
RalfJung:miri-assert-error-sanity

Conversation

@RalfJung

@RalfJungRalfJung commented Mar 10, 2020

Copy link
Copy Markdown
Member

We had these as debug assertions so far to make sure our test suite is clean, but really these are conditions that should never arise and also @eddyb told me to turn non-performance-critical debug assertions into full assertions so here we go. ;)

I propose that we do a check-only crater run to make sure this does not actually happen in practice.

r? @oli-obk

@RalfJung

RalfJung commented Mar 10, 2020

Copy link
Copy Markdown
MemberAuthor

@bors try

bors added a commit that referenced this pull request Mar 10, 2020
@bors
Auto merge of#69880- RalfJung:miri-assert-error-sanity, r=<try>
13f916f
miri engine: turn error sanity checks into assertions
We had these as debug assertions so far to make sure our test suite is clean, but really these are conditions that should never arise and also @eddyb told me to turn non-performance-critical debug assertions into full assertions so here we go. ;)
I propose that we do a check-only crater run to make sure this does not actually happen in practice.
r? @oli-obk
@bors

bors commented Mar 10, 2020

Copy link
Copy Markdown
Collaborator

⌛ Trying commit afc9cf3 with merge 13f916f...

@bors

bors commented Mar 10, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-azure
Build commit: 13f916f (13f916f63bc6575d5ff1f989237dfabe88981368)

@RalfJungRalfJung added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2020
@Centril

Centril commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

@craterbot check

@craterbot

craterbot commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-69880 created and queued.
🤖 Automatically detected try build 13f916f
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbotcraterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2020
@craterbot

craterbot commented Mar 13, 2020

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-69880 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

craterbot commented Mar 16, 2020

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-69880 is completed!
📊 1 regressed and 3 fixed (95301 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbotcraterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 16, 2020
@RalfJung

RalfJung commented Mar 17, 2020

Copy link
Copy Markdown
MemberAuthor

Hm, that regression is interesting: broken MIR in DefId(0:37 ~ ice_testcase[f77b]::problematic_function[0]). Doesn't sound like it would come from this PR? ice_testcase is also a funny name for that crate. ;)

@RalfJung

RalfJung commented Mar 21, 2020

Copy link
Copy Markdown
MemberAuthor

@oli-obk I think this is ready to go, and crater didn't find any regression.

@oli-obk

oli-obk commented Mar 22, 2020

Copy link
Copy Markdown
Contributor

r=me after a rebase

@RalfJung
RalfJungforce-pushed the miri-assert-error-sanity branch from afc9cf3 to 2ee2157CompareMarch 22, 2020 21:49
@RalfJung

RalfJung commented Mar 22, 2020

Copy link
Copy Markdown
MemberAuthor

Ah I hadn't even realized there was a conflict (looks like bors missed it too). Done!

@bors r=oli-obk

@bors

bors commented Mar 22, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2ee2157 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 22, 2020
@CentrilCentril mentioned this pull request Mar 23, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2020
@bors
Auto merge ofrust-lang#70296- Centril:rollup-wvfmb3n, r=Centril
8ff7850
Rollup of 9 pull requests
Successful merges:
- rust-lang#69251 (#[track_caller] in traits)
- rust-lang#69880 (miri engine: turn error sanity checks into assertions)
- rust-lang#70207 (Use getentropy(2) on macos)
- rust-lang#70227 (Only display definition when suggesting a typo)
- rust-lang#70236 (resolve: Avoid "self-confirming" import resolutions in one more case)
- rust-lang#70248 (parser: simplify & remove unused field)
- rust-lang#70249 (handle ConstKind::Unresolved after monomorphizing)
- rust-lang#70269 (remove redundant closures (clippy::redundant_closure))
- rust-lang#70270 (Clean up E0449 explanation)
Failed merges:
r? @ghost
@bors
bors merged commit a2b469c into rust-lang:masterMar 23, 2020
@RalfJung
RalfJung deleted the miri-assert-error-sanity branch March 24, 2020 08:58
@RalfJungRalfJung mentioned this pull request Apr 22, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RalfJung@bors@Centril@craterbot@oli-obk