Skip to content

librustc_codegen_llvm: Use slices instead of 0-terminated strings - #69893

Merged
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:cstr
Mar 11, 2020
Merged

librustc_codegen_llvm: Use slices instead of 0-terminated strings#69893
bors merged 1 commit into
rust-lang:masterfrom
tmiasko:cstr

Conversation

@tmiasko

@tmiaskotmiasko commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

Changed functions:

  • LLVMRustGetOrInsertFunction
  • LLVMRustGetNamedValue
  • LLVMRustBuildCall (removed unused name argument)
  • LLVMRustInlineAsm
  • LLVMRustInlineAsmVerify
  • LLVMRustAppendModuleInlineAsm

@rust-highfive

rust-highfive commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2020
petrochenkov
petrochenkov reviewed Mar 10, 2020
View reviewed changes
Comment threadsrc/rustllvm/RustWrapper.cpp Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2020
@petrochenkov

petrochenkov commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

Thanks!
@bors r+

@bors

bors commented Mar 10, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 3811a63d93980269a5a8f692dc336e7e0da0bb1c has been approved by petrochenkov

@bors

bors commented Mar 10, 2020

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 10, 2020
@tmiaskotmiasko changed the title librustc_codegen_llvm: Use slices instead of 0-termianted stringslibrustc_codegen_llvm: Use slices instead of 0-terminated stringsMar 11, 2020
@tmiasko
librustc_codegen_llvm: Use slices instead of 0-terminated strings
1106579
Changed functions:
* LLVMRustGetOrInsertFunction
* LLVMRustGetNamedValue
* LLVMRustBuildCall (removed unused name argument)
* LLVMRustInlineAsm
* LLVMRustInlineAsmVerify
* LLVMRustAppendModuleInlineAsm
@tmiasko

tmiasko commented Mar 11, 2020

Copy link
Copy Markdown
ContributorAuthor

Amended the commit message to remove the typo.

@petrochenkov

petrochenkov commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1106579 has been approved by petrochenkov

@CentrilCentril mentioned this pull request Mar 11, 2020
Merged
bors added a commit that referenced this pull request Mar 11, 2020
@bors
Auto merge of#69919- Centril:rollup-fxo33zs, r=Centril
c20d7ee
Rollup of 8 pull requests
Successful merges:
- #66472 (--show-coverage json)
- #69603 (tidy: replace `make check` with `./x.py test` in documentation)
- #69760 (Improve expression & attribute parsing)
- #69828 (fix memory leak when vec::IntoIter panics during drop)
- #69850 (panic_bounds_check: use caller_location, like PanicFnLangItem)
- #69876 (Add long error explanation for E0739)
- #69888 ([Miri] Use a session variable instead of checking for an env var always)
- #69893 (librustc_codegen_llvm: Use slices instead of 0-terminated strings)
Failed merges:
r? @ghost
@bors
bors merged commit a77206f into rust-lang:masterMar 11, 2020
@JohnTitorJohnTitor mentioned this pull request Mar 12, 2020
Closed
@tmiasko
tmiasko deleted the cstr branch March 21, 2020 07:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmiasko@rust-highfive@petrochenkov@bors