Uh oh!
There was an error while loading. Please reload this page.
Evaluate repeat expression lengths as late as possible - #69981
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Uh oh!
There was an error while loading. Please reload this page.
varkor
commented
Mar 14, 2020
Sorry, I've had a half-finished branch to do this for a couple of months, but haven't managed to get back to it. Thanks for taking it on. I'll have a look soon. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
I wonder when we can have mk_array take a ty::Const.
There was a problem hiding this comment.
Likely never, we have 14 uses in the code base, and half of them are ProjectionKind::SubSlice related.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
rust-highfive
commented
Mar 14, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Mar 14, 2020
☔ The latest upstream changes (presumably #69076) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-highfive
commented
Mar 14, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
There was a problem hiding this comment.
This span could use some improvement
Uh oh!
There was an error while loading. Please reload this page.
…unimplemented, r=eddyb Fiddle `ParamEnv` through to a place that used to use `ParamEnv::empty` in a buggy manner cc rust-lang#69981 (comment) r? @eddyb
…unimplemented, r=eddyb Fiddle `ParamEnv` through to a place that used to use `ParamEnv::empty` in a buggy manner cc rust-lang#69981 (comment) r? @eddyb
…unimplemented, r=eddyb Fiddle `ParamEnv` through to a place that used to use `ParamEnv::empty` in a buggy manner cc rust-lang#69981 (comment) r? @eddyb
eddyb
commented
Mar 23, 2020
Sigh, it's that silly error again. (although I suppose a bunch of the |
oli-obk
commented
Mar 23, 2020
@bors r=eddyb |
bors
commented
Mar 23, 2020
📌 Commit 4f513b5 has been approved by |
Evaluate repeat expression lengths as late as possible Fixesrust-lang#68567 r? @varkor
Centril
commented
Mar 23, 2020
You need to |
rust-highfive
commented
Mar 23, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
oli-obk
commented
Mar 23, 2020
@bors r=eddyb |
bors
commented
Mar 23, 2020
📌 Commit 9b1893f has been approved by |
Rollup of 11 pull requests Successful merges: - rust-lang#67761 (Move the dep_graph construction to a dedicated crate.) - rust-lang#69740 (Replace some desc logic in librustc_lint with article_and_desc) - rust-lang#69981 (Evaluate repeat expression lengths as late as possible) - rust-lang#70087 (Remove const eval loop detector) - rust-lang#70242 (Improve E0308 error message wording) - rust-lang#70264 (Fix invalid suggestion on `&mut` iterators yielding `&` references) - rust-lang#70267 (get rid of ConstPropUnsupported; use ZST marker structs instead) - rust-lang#70277 (Remove `ReClosureBound`) - rust-lang#70283 (Add regression test for rust-lang#70155.) - rust-lang#70294 (Account for bad placeholder types in where clauses) - rust-lang#70309 (Clean up E0452 explanation) Failed merges: r? @ghost
Fixes#68567
r? @varkor