Uh oh!
There was an error while loading. Please reload this page.
def_collector: Fully visit async functions - #70011
Merged
Merged
Conversation
rust-highfive
commented
Mar 14, 2020
Contributor
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
ContributorAuthor
Actually, maybe this can be cleaned up to only specialize UPDATE: Done. |
Centril
commented
Mar 15, 2020
Contributor
bors
commented
Mar 15, 2020
Collaborator
📌 Commit 2093d83 has been approved by |
bors added a commit
that referenced
this pull request
Mar 15, 2020
Rollup of 8 pull requests Successful merges: - #69528 (Add undo_leak to reset RefCell borrow state) - #69589 (ast: `Mac`/`Macro` -> `MacCall`) - #69661 (Implement From<&mut str> for String) - #69988 (rustc_metadata: Remove `rmeta::MacroDef`) - #70006 (resolve: Fix two issues in fresh binding disambiguation) - #70011 (def_collector: Fully visit async functions) - #70013 (Return feature gate as a `Symbol` ) - #70018 (Fix "since" field for `Once::is_complete`'s `#[stable]` attribute) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We forgot to visit attributes previously, it caused ICEs.
Special treatment of async functions is also moved from
visit_itemtovisit_fnto reuse more of the default visitor.Fixes#67778.