Skip to content

submodules: update clippy from 8485d40a to d556bb73 - #70020

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:submodule_upd
Mar 18, 2020
Merged

submodules: update clippy from 8485d40a to d556bb73#70020
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:submodule_upd

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Mar 15, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Changes:

 rustup https://github.com/rust-lang/rust/pull/68944
rustup https://github.com/rust-lang/rust/pull/69589/
Rustup to rust-lang/rust#69076
Don't convert Path to lossy str
Use `into_path`
Use pattern matching instead of manually checking condition
Fix typo
Remove git2 dependency.
Document that wildcard_imports doesn't warn about `use ...::prelude::*;`
Change changelog formatting
Update changelog_update doc to reflect the actual ordering of the changelog
Update CHANGELOG.md

Fixes#70007

@rust-highfive

rust-highfive commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

rust-highfive commented Mar 15, 2020

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2020
@Dylan-DPC-zz

Dylan-DPC-zz commented Mar 16, 2020

Copy link
Copy Markdown

@bors r+

@bors

bors commented Mar 16, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit be7519740de8ca53d87ce77b9c22231d51028766 has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2020
@ehuss

ehuss commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

@bors p=1
Unblocks cargo, and fixes toolstate.

@matthiaskrgr

matthiaskrgr commented Mar 16, 2020

Copy link
Copy Markdown
MemberAuthor

This is currently blocked on rust-lang/rust-clippy#5321

@Dylan-DPC-zz

Dylan-DPC-zz commented Mar 16, 2020

Copy link
Copy Markdown

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 16, 2020
@matthiaskrgrmatthiaskrgr changed the title submodules: update clippy from 8485d40a to 8fd7e31dsubmodules: update clippy from 8485d40a to d556bb73Mar 16, 2020
@matthiaskrgr
submodules: update clippy from8485d40to23549a8
7e2ebb0
Changes:
````
rustup rust-lang#69738
rustup rust-lang#68944
Make use of `or_patterns` feature
rustup rust-lang#69589
Rustup to rust-lang#69076
Don't convert Path to lossy str
Use `into_path`
Use pattern matching instead of manually checking condition
Fix typo
Remove git2 dependency.
Document that wildcard_imports doesn't warn about `use ...::prelude::*;`
Change changelog formatting
Update changelog_update doc to reflect the actual ordering of the changelog
Update CHANGELOG.md
````
Fixesrust-lang#70007
@matthiaskrgr

matthiaskrgr commented Mar 16, 2020

Copy link
Copy Markdown
MemberAuthor

Should be in sync again.

@ehuss

ehuss commented Mar 16, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 16, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 7e2ebb0 has been approved by ehuss

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 16, 2020
@Manishearth

Manishearth commented Mar 17, 2020

Copy link
Copy Markdown
Member

@bors p=20

@bors

bors commented Mar 17, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7e2ebb0 with merge ae5b641...

@bors

bors commented Mar 18, 2020

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing ae5b641 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Mar 18, 2020
@bors
bors merged commit ae5b641 into rust-lang:masterMar 18, 2020
@rust-highfive

rust-highfive commented Mar 18, 2020

Copy link
Copy Markdown
Contributor

📣 Toolstate changed by #70020!

Tested on commit ae5b641.
Direct link to PR: #70020

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Mar 18, 2020
@rust-highfive
📣 Toolstate changed byrust-lang/rust#70020!
cc679c4
Tested on commit rust-lang/rust@ae5b641.
Direct link to PR: <rust-lang/rust#70020>
🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton@oli-obk@Manishearth@flip1995@yaahc@phansch@llogiq).
@matthiaskrgr
matthiaskrgr deleted the submodule_upd branch March 18, 2020 01:46
@matthiaskrgr

matthiaskrgr commented Mar 18, 2020

Copy link
Copy Markdown
MemberAuthor

It barely missed the nightly cutoff 😢

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakisnikomatsakis

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

clippy-driver no longer builds after rust-lang/rust#69076

7 participants

@matthiaskrgr@rust-highfive@Dylan-DPC-zz@bors@ehuss@Manishearth@nikomatsakis