ci: use python from the correct path by emilyalbini · Pull Request #70116 · rust-lang/rust

emilyalbini · 2020-03-18T18:04:25Z

Apparently the old path we were using for Python 2 on Windows was not documented, and eventually got removed. This switches our CI to use the correct path.

See #70112 (comment) for the actual failure.

rust-highfive · 2020-03-18T18:04:29Z

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

emilyalbini · 2020-03-18T18:04:33Z

@bors try

bors · 2020-03-18T18:04:44Z

⌛ Trying commit e958ccf3e89ca82f598e5db35c1754e404977d18 with merge 95992c163b7300535652916cf07b3f1e764c9e13...

Mark-Simulacrum

r=me when ready

Mark-Simulacrum · 2020-03-18T18:05:36Z

I can't say that this directory name exactly inspires confidence :)

Heh, at least it's somewhat documented.

rust-highfive · 2020-03-18T18:11:46Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

emilyalbini · 2020-03-18T18:12:14Z

@bors try

bors · 2020-03-18T18:12:25Z

⌛ Trying commit 389b4a8e2351e795c32113f92401b923f38e2789 with merge 53f6756b58da4fd288d3994309ce95ef5343063e...

rust-highfive · 2020-03-18T18:19:01Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-03-18T18:19:01Z

💔 Test failed - checks-azure

emilyalbini · 2020-03-18T18:22:51Z

@bors try

bors · 2020-03-18T18:23:01Z

⌛ Trying commit 3c2c4f1701704e1cfdd06e960553d67dac4c4e8b with merge 5434638a2d9607ecbb9be95a4c6f905f8f536b79...

emilyalbini · 2020-03-18T18:32:15Z

Ok this works now 🎉

@bors r=Mark-Simulacrum p=1000

bors · 2020-03-18T18:32:17Z

📌 Commit 679e14837946f272d163c0c3c1dd825ab683a517 has been approved by Mark-Simulacrum

bors · 2020-03-18T18:32:18Z

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

bors · 2020-03-18T18:32:28Z

⌛ Testing commit 679e14837946f272d163c0c3c1dd825ab683a517 with merge 6a305af9cf7511487b83085a8db359f9e754a440...

rust-highfive · 2020-03-18T18:40:36Z

The job i686-gnu of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-18T18:39:39.0976656Z [RUSTC-TIMING] tidy test:false 0.715
2020-03-18T18:39:39.1040467Z Finished release [optimized] target(s) in 1m 40s
2020-03-18T18:39:39.1088269Z [TIMING] ToolBuild { compiler: Compiler { stage: 0, host: "i686-unknown-linux-gnu" }, target: "i686-unknown-linux-gnu", tool: "tidy", path: "src/tools/tidy", mode: ToolBootstrap, is_optional_tool: false, source_type: InTree, extra_features: [] } -- 100.917
2020-03-18T18:39:39.1089074Z tidy check
2020-03-18T18:39:39.8705603Z tidy error: /checkout/src/ci/scripts/install-msys2-packages.sh:16: line longer than 100 chars
2020-03-18T18:39:43.0141977Z Found 489 error codes
2020-03-18T18:39:43.0142779Z Found 0 error codes with no tests
2020-03-18T18:39:43.0143193Z Done!
2020-03-18T18:39:43.0143535Z some tidy checks failed
2020-03-18T18:39:43.0143535Z some tidy checks failed
2020-03-18T18:39:43.0143965Z 2020-03-18T18:39:43.0144241Z 2020-03-18T18:39:43.0145824Z command did not execute successfully: "/checkout/obj/build/i686-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/i686-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2020-03-18T18:39:43.0147110Z 2020-03-18T18:39:43.0147353Z 2020-03-18T18:39:43.0148498Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/bootstrap --exclude src/test/rustdoc-js --exclude src/tools/error_index_generator --exclude src/tools/linkchecker
2020-03-18T18:39:43.0149346Z Build completed unsuccessfully in 0:01:54
2020-03-18T18:39:43.0149346Z Build completed unsuccessfully in 0:01:54
2020-03-18T18:39:43.0149805Z == clock drift check ==
2020-03-18T18:39:43.0150261Z local time: Wed Mar 18 18:39:42 UTC 2020
2020-03-18T18:39:43.0150783Z network time: Wed, 18 Mar 2020 18:39:42 GMT
2020-03-18T18:39:43.2714926Z == end clock drift check ==
2020-03-18T18:39:43.2958938Z 2020-03-18T18:39:43.3002923Z ##[error]Bash exited with code '1'.
2020-03-18T18:39:43.3078269Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-03-18T18:39:43.3083777Z ==============================================================================
2020-03-18T18:39:43.3084239Z Task : Get sources
2020-03-18T18:39:43.3084688Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-03-18T18:40:51Z

💔 Test failed - checks-azure

Apparently the old path we were using for Python 2 on Windows was not documented, and eventually got removed. This switches our CI to use the correct path.

emilyalbini · 2020-03-18T20:08:48Z

Fixed tidy.

@bors r=Mark-Simulacrum p=1

bors · 2020-03-18T20:08:50Z

📌 Commit 779e592 has been approved by Mark-Simulacrum

bors · 2020-03-18T20:09:05Z

⌛ Testing commit 779e592 with merge add58520c194e8658888efdf1ffc4f81fb5af833...

@ghost

Rollup of 2 pull requests Successful merges: - #70112 (Rollup of 10 pull requests) - #70116 (ci: use python from the correct path) Failed merges: r? @ghost

emilyalbini · 2020-03-18T20:12:33Z

@bors retry

Yield priority.

@ghost

Rollup of 2 pull requests Successful merges: - #70112 (Rollup of 10 pull requests) - #70116 (ci: use python from the correct path) Failed merges: r? @ghost

Mark-Simulacrum · 2020-03-20T14:44:29Z

(Accepting for stable backport as intrinsically required for any stable release, but obviously not going to produce one just because of this).

…ulacrum [beta] backport rollup This backports: * can_begin_literal_maybe_minus: `true` on `"-"? lit` NTs. rust-lang#70058 * ci: use python from the correct path rust-lang#70116 * Update stdarch submodule rust-lang#70151 (superseding and closing rust-lang#70221) * Beta: Update cargo, clippy rust-lang#70105 (also closing that beta-targeted PR) It also switches the bootstrap compiler to download from static.rust-lang.org from dev-static.rust-lang.org.

cuviper · 2020-05-01T19:49:51Z

Clearing stable-nominated -- we never did a point release for 1.42, and #70244 went into 1.43.

rust-highfive assigned Mark-Simulacrum Mar 18, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2020

Mark-Simulacrum approved these changes Mar 18, 2020
View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2020

emilyalbini force-pushed the ci-fix-windows-python-path branch from 389b4a8 to 3c2c4f1Compare March 18, 2020 18:22

emilyalbini force-pushed the ci-fix-windows-python-path branch from 3c2c4f1 to 679e148Compare March 18, 2020 18:30

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 18, 2020

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 18, 2020

bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 18, 2020

ci: use python from the correct path
779e592
Apparently the old path we were using for Python 2 on Windows was not documented, and eventually got removed. This switches our CI to use the correct path.

emilyalbini force-pushed the ci-fix-windows-python-path branch from 679e148 to 779e592Compare March 18, 2020 20:08

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2020

emilyalbini mentioned this pull request Mar 18, 2020
Rollup of 2 pull requests #70118
Merged

bors added a commit that referenced this pull request Mar 18, 2020
Auto merge of#70118- pietroalbini:rollup-pgjc90i, r=pietroalbini
631dd9e
Rollup of 2 pull requests Successful merges: - #70112 (Rollup of 10 pull requests) - #70116 (ci: use python from the correct path) Failed merges: r? @ghost

bors added a commit that referenced this pull request Mar 19, 2020
Auto merge of#70118- pietroalbini:rollup-pgjc90i, r=pietroalbini
57e1da5
Rollup of 2 pull requests Successful merges: - #70112 (Rollup of 10 pull requests) - #70116 (ci: use python from the correct path) Failed merges: r? @ghost

bors merged commit 94ed071 into rust-lang:masterMar 19, 2020

emilyalbini deleted the ci-fix-windows-python-path branch March 19, 2020 10:25

Mark-Simulacrum added the stable-accepted Accepted for backporting to the compiler in the stable channel. label Mar 20, 2020

SimonSapin mentioned this pull request Mar 20, 2020
Importing modules from inside include! no longer works #70185
Closed

Mark-Simulacrum mentioned this pull request Mar 21, 2020
[beta] backport rollup #70244
Merged

Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 21, 2020

cuviper removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label May 1, 2020

Uh oh!

Uh oh!

Conversation

emilyalbini commented Mar 18, 2020

Uh oh!

rust-highfive commented Mar 18, 2020

Uh oh!

emilyalbini commented Mar 18, 2020

Uh oh!

bors commented Mar 18, 2020

Uh oh!

Mark-Simulacrum left a comment

Choose a reason for hiding this comment

Uh oh!

Mark-SimulacrumMar 18, 2020

Choose a reason for hiding this comment

Uh oh!

emilyalbiniMar 18, 2020

Choose a reason for hiding this comment

Uh oh!

rust-highfive commented Mar 18, 2020

Uh oh!

emilyalbini commented Mar 18, 2020

Uh oh!

bors commented Mar 18, 2020

Uh oh!

rust-highfive commented Mar 18, 2020

Uh oh!

bors commented Mar 18, 2020

Uh oh!

emilyalbini commented Mar 18, 2020

Uh oh!

bors commented Mar 18, 2020

Uh oh!

emilyalbini commented Mar 18, 2020

Uh oh!

bors commented Mar 18, 2020

Uh oh!

bors commented Mar 18, 2020

Uh oh!

bors commented Mar 18, 2020

Uh oh!

rust-highfive commented Mar 18, 2020

Uh oh!

bors commented Mar 18, 2020

Uh oh!

emilyalbini commented Mar 18, 2020

Uh oh!

bors commented Mar 18, 2020

Uh oh!

bors commented Mar 18, 2020

Uh oh!

emilyalbini commented Mar 18, 2020

Uh oh!

Mark-Simulacrum commented Mar 20, 2020

Uh oh!

cuviper commented May 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants