Uh oh!
There was an error while loading. Please reload this page.
doc: Add quote to .init_array - #70145
Merged
Merged
Conversation
rust-highfive
commented
Mar 19, 2020
Contributor
r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
tesuji
commented
Mar 19, 2020
ContributorAuthor
r? @joshtriplett as reviewer of #66547. |
Dylan-DPC-zz
commented
Mar 19, 2020
Wouldn't it be better to use ` instead of quotes? |
Dylan-DPC-zz
commented
Mar 19, 2020
r? @Dylan-DPC |
ContributorAuthor
I don't have strong opinion on this. But I vaguely remembered one Rust member Here the doc after using backtick |
Dylan-DPC-zz
commented
Mar 19, 2020
@bors r+ rollup |
bors
commented
Mar 19, 2020
Collaborator
📌 Commit 2c38ecf has been approved by |
tesuji
commented
Mar 19, 2020
ContributorAuthor
Just to be sure: Currently I still use double quote ( |
Dylan-DPC-zz
commented
Mar 19, 2020
Yes I'm aware. It is fine no worries |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 19, 2020
doc: Add quote to .init_array The current formatting is not good without quotes: 
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 20, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#69618 (Clarify the relationship between `forget()` and `ManuallyDrop`.) - rust-lang#69768 (Compute the correct layout for variants of uninhabited enums) - rust-lang#69935 (codegen/mir: support polymorphic `InstanceDef`s) - rust-lang#70103 (Clean up E0437 explanation) - rust-lang#70131 (Add regression test for TAIT lifetime inference (issue rust-lang#55099)) - rust-lang#70133 (remove unused imports) - rust-lang#70145 (doc: Add quote to .init_array) - rust-lang#70146 (Clean up e0438 explanation) - rust-lang#70150 (triagebot.toml: accept cleanup-crew) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current formatting is not good without quotes:
