ty/walk: iterate `GenericArg`s instead of `Ty`s. by eddyb · Pull Request #70164 · rust-lang/rust

eddyb · 2020-03-19T19:23:04Z

Before this PR, Ty::walk only iterated over Tys, but that's becoming an increasing problem with const generics, as ty::Consts in Substs are missed by it.

By working with GenericArg instead, we can handle both Tys and ty::Consts, but also ty::Regions, which used to require ad-hoc mechanisms such as push_regions.

I've also removed TraitRef::input_types, as it's both long obsolete, and easy to misuse.

eddyb · 2020-03-19T19:23:33Z

r? @nikomatsakis cc @matthewjasper @varkor @yodaldevoid

eddyb · 2020-03-19T19:24:55Z

I'm doing a perf run with just commit, to assess the impact of collecting ty::Regions and ty::Consts besides just Tys, without exposing non-Tys in the Ty::walk API:

ty/walk: keep track of GenericArgs on the stack, instead of Tys.

@bors try @rust-timer queue

rust-timer · 2020-03-19T19:24:56Z

Awaiting bors try build completion

bors · 2020-03-19T19:25:05Z

⌛ Trying commit 27d6047f0fc787370b110688389204e2c4c57bc6 with merge e8f55d1b486e3355f5cb9b8252d069943e421ac0...

bors · 2020-03-19T22:09:07Z

☀️ Try build successful - checks-azure
Build commit: e8f55d1b486e3355f5cb9b8252d069943e421ac0 (e8f55d1b486e3355f5cb9b8252d069943e421ac0)

rust-timer · 2020-03-19T22:09:08Z

Queued e8f55d1b486e3355f5cb9b8252d069943e421ac0 with parent f4c675c, future comparison URL.

rust-timer · 2020-03-20T01:10:15Z

Finished benchmarking try commit e8f55d1b486e3355f5cb9b8252d069943e421ac0, comparison URL.

eddyb · 2020-03-20T01:16:35Z

Looks harmless, I guess? I'll finish the PR assuming the first commit is acceptable.

eddyb · 2020-04-06T20:15:30Z

@bors r=nikomatsakis rollup=never (just in case we get another surprise)

bors · 2020-04-06T20:15:32Z

📌 Commit 626abc7 has been approved by nikomatsakis

Dylan-DPC-zz · 2020-04-07T00:17:56Z

@bors p=1

bors · 2020-04-07T04:01:32Z

⌛ Testing commit 626abc7 with merge 209b2be...

bors · 2020-04-07T07:12:43Z

☀️ Test successful - checks-azure
Approved by: nikomatsakis
Pushing 209b2be to master...

rust-highfive · 2020-04-07T07:13:59Z

📣 Toolstate changed by #70164!

Tested on commit 209b2be.
Direct link to PR: #70164

💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).
💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

@mcarton

Tested on commit rust-lang/rust@209b2be. Direct link to PR: <rust-lang/rust#70164> 💔 clippy-driver on windows: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq). 💔 clippy-driver on linux: test-pass → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq).

@nikomatsakis

…r=nikomatsakis outlives: ignore lifetimes shallowly found in `ty::FnDef`s. Fixesrust-lang#70917 by restoring the pre-rust-lang#70164 behavior for now. r? @nikomatsakis

rust-highfive assigned petrochenkov Mar 19, 2020

This comment has been minimized.
Sign in to view

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 19, 2020

rust-highfive assigned nikomatsakis and unassigned petrochenkov Mar 19, 2020

eddyb mentioned this pull request Mar 19, 2020
WF-check all ty::Const's, not just array lengths. #70107
Merged

varkor added the F-const_generics `#![feature(const_generics)]` label Mar 19, 2020

eddyb mentioned this pull request Mar 20, 2020
[WIP] traits/fulfill: track GenericArgss instead of InferTys in stalled_on. #70181
Closed

eddyb mentioned this pull request Mar 21, 2020
traits/fulfill: allow stalled_on to track ty::Const::Infer(_) (unused yet). #70213
Merged

eddyb force-pushed the walk-generic-arg branch from 27d6047 to 135ee05Compare March 22, 2020 02:08

This comment has been minimized.
Sign in to view

eddyb added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Mar 22, 2020

eddyb force-pushed the walk-generic-arg branch from 135ee05 to 7be2176Compare March 22, 2020 05:35

eddyb mentioned this pull request Mar 22, 2020
typeck/type_of: let wfcheck handle generics in opaque types' substs. #70272
Merged

This comment has been minimized.
Sign in to view

eddyb force-pushed the walk-generic-arg branch from f76e2f1 to 10d72f0Compare March 23, 2020 03:45

eddyb mentioned this pull request Mar 23, 2020
Make it a bit easier to debug TyKind::Error errors #70245
Closed

eddyb changed the title ~~[WIP] ty/walk: iterate GenericArgs instead of Tys.~~ty/walk: iterate GenericArgs instead of Tys.Mar 23, 2020

eddyb added 3 commits April 6, 2020 21:55

ty: switch Ty::walk from Ty to GenericArg.
3410aed

ty: remove unnecessary Predicate::walk_tys and collect_regions.
b7fdc7b

ty: remove {Existential,}Trait{Ref,Predicate}::input_types.
626abc7

eddyb force-pushed the walk-generic-arg branch from 0ca1e7a to 626abc7Compare April 6, 2020 19:59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2020

mark-i-m mentioned this pull request Apr 6, 2020
Don't (ab)use TyKind::Error when not planning to emit error #70866
Closed
8 tasks

mark-i-m mentioned this pull request Apr 7, 2020
Make all uses of ty::Error delay a span bug #70551
Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 7, 2020

bors merged commit 209b2be into rust-lang:masterApr 7, 2020

rust-highfive mentioned this pull request Apr 7, 2020
clippy-driver no longer builds after rust-lang/rust#70164 #70875
Closed

This was referenced Apr 7, 2020
fix misleading type annotation diagonstics #69456
Merged
perf: Unify the undo log of all snapshot types #69464
Merged

eddyb deleted the walk-generic-arg branch April 7, 2020 09:45

JohnTitor mentioned this pull request Apr 8, 2020
Rustup to the latest nightly rust-lang/rust-semverver#116
Merged

Centril mentioned this pull request Apr 8, 2020
Compile regression "cannot infer an appropriate lifetime for lifetime parameter" #70917
Closed

eddyb commented Apr 16, 2020
View reviewed changes

Comment threadsrc/librustc_middle/ty/sty.rs

eddyb mentioned this pull request Apr 16, 2020
outlives: ignore lifetimes shallowly found in ty::FnDefs. #71218
Merged

eddyb mentioned this pull request May 25, 2020
add regression tests for stalled_on const vars #72061
Merged

varkor mentioned this pull request Jul 22, 2020
Tracking issue for const generics (RFC 2000) #44580
Closed
16 tasks

oli-obk mentioned this pull request May 12, 2026
'static closures/FnDefs/futures with non-'static return type are unsound #84366
Open

Uh oh!

Uh oh!

Conversation

eddyb commented Mar 19, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

eddyb commented Mar 19, 2020

Uh oh!

eddyb commented Mar 19, 2020

Uh oh!

rust-timer commented Mar 19, 2020

Uh oh!

bors commented Mar 19, 2020

Uh oh!

bors commented Mar 19, 2020

Uh oh!

rust-timer commented Mar 19, 2020

Uh oh!

rust-timer commented Mar 20, 2020

Uh oh!

eddyb commented Mar 20, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

eddyb commented Apr 6, 2020

Uh oh!

bors commented Apr 6, 2020

Uh oh!

Dylan-DPC-zz commented Apr 7, 2020

Uh oh!

bors commented Apr 7, 2020

Uh oh!

bors commented Apr 7, 2020

Uh oh!

rust-highfive commented Apr 7, 2020

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

eddyb commented Mar 19, 2020•
edited
Loading