Uh oh!
There was an error while loading. Please reload this page.
Liberate rustc_ast_lowering from rustc - #70204
Merged
Merged
Conversation
Centrilforce-pushed
the
unshackled-lowering
branch
from
March 21, 2020 04:51
74cf684 to
5746fd4Compare
This comment has been minimized.
This comment has been minimized.
Centrilforce-pushed
the
unshackled-lowering
branch
from
March 21, 2020 21:25
5746fd4 to
40cec78CompareZoxc
commented
Mar 22, 2020
Contributor
@bors try @rust-timer queue |
rust-timer
commented
Mar 22, 2020
Collaborator
Awaiting bors try build completion |
bors
commented
Mar 22, 2020
Collaborator
⌛ Trying commit 40cec78 with merge f60543b065b8eff6ea6ea5d5a66f80541574b97e... |
Zoxc
commented
Mar 22, 2020
Contributor
r=me if perf is fine |
bors
commented
Mar 22, 2020
Collaborator
☀️ Try build successful - checks-azure |
rust-timer
commented
Mar 22, 2020
Collaborator
Queued f60543b065b8eff6ea6ea5d5a66f80541574b97e with parent 1902d1e, future comparison URL. |
rust-timer
commented
Mar 23, 2020
Collaborator
Finished benchmarking try commit f60543b065b8eff6ea6ea5d5a66f80541574b97e, comparison URL. |
Zoxc
commented
Mar 23, 2020
Contributor
That's an unexpected perf result :/ @bors r+ |
bors
commented
Mar 23, 2020
Collaborator
📌 Commit 40cec78 has been approved by |
ContributorAuthor
@bors rollup=never p=1 (perf) |
bors
commented
Mar 23, 2020
Collaborator
bors
commented
Mar 23, 2020
Collaborator
☀️ Test successful - checks-azure |
This was referenced Mar 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole point of this PR is the very last commit, in which we remove
rustcas one ofrustc_ast_lowering's dependencies, thereby improving./x.pyparallelism and working towards #65031.Noteworthy:
rustc::arenawe move logic intoarena, in particulardeclare_arena!. This is then used inrustc_ast_loweringso that lowering has its own separate arena.rustc_session::lintcause its used both inrustc_lintandrustc_ast_lowering, and this is their common dependency.rustc_session::CrateDisambiguatoris moved intorustc_astso thatrustc::hir::map::definitionscan be moved intorustc_hir, so thatrustc_ast_loweringcan stop referring torustc::hir.r? @Zoxc