Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #70288
Closed
Dylan-DPC-zz wants to merge 19 commits into
Closed
Conversation
Previously, we threw away the `Span` associated with a definition's identifier when we encoded crate metadata, causing us to lose location and hygiene information. We now store the identifier's `Span` in the crate metadata. When we decode items from the metadata, we combine the name and span back into an `Ident`. This improves the output of several tests, which previously had messages suppressed due to dummy spans. This is a prerequisite for rust-lang#68686, since throwing away a `Span` means that we lose hygiene information.
…hewjasper Increase verbosity when suggesting subtle code changes Do not suggest changes that are actually quite small inline, to minimize the likelihood of confusion. Fixrust-lang#69243.
…t, r=petrochenkov Store idents for `DefPathData` into crate metadata Previously, we threw away the `Span` associated with a definition's identifier when we encoded crate metadata, causing us to lose location and hygiene information. We now store the identifier's `Span` in a side table, which gets encoded into the crate metadata. When we decode items from the metadata, we combine the name and span back into an `Ident`. This improves the output of several tests, which previously had messages suppressed due to dummy spans. This is a prerequisite for rust-lang#68686, since throwing away a `Span` means that we lose hygiene information.
Only display definition when suggesting a typo Closesrust-lang#70206 r? @Centril
parser: simplify & remove unused field r? @petrochenkov
handle ConstKind::Unresolved after monomorphizing fixesrust-lang#70125 r? @bjorn3
…an-DPC remove redundant closures (clippy::redundant_closure)
Dylan-DPC-zz
commented
Mar 22, 2020
Author
@bors r+ rollup=never p=6 |
bors
commented
Mar 22, 2020
Collaborator
📌 Commit f063531 has been approved by |
bors
commented
Mar 23, 2020
Collaborator
⌛ Testing commit f063531 with merge e2e5829e1855a511780c0f36b44831216a7e3b61... |
bors
commented
Mar 23, 2020
Collaborator
💔 Test failed - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
DefPathDatainto crate metadata #70077 (Store idents forDefPathDatainto crate metadata)Failed merges:
r? @ghost