Skip to content

Update RELEASES.md for 1.43.0 - #70354

Merged
bors merged 12 commits into
rust-lang:masterfrom
XAMPPRocky:master
Apr 16, 2020
Merged

Update RELEASES.md for 1.43.0#70354
bors merged 12 commits into
rust-lang:masterfrom
XAMPPRocky:master

Conversation

@XAMPPRocky

@XAMPPRockyXAMPPRocky commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

Rendered

r? @Mark-Simulacrum

cc @rust-lang/release

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2020
kellerkindt
kellerkindt reviewed Mar 24, 2020
View reviewed changes
Comment threadRELEASES.md Outdated
LeSeulArtichaut
LeSeulArtichaut reviewed Mar 24, 2020
View reviewed changes
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
XAMPPRockyand others added 3 commits March 24, 2020 16:07
@XAMPPRocky@LeSeulArtichaut
Apply suggestions from code review
f1f91c9
Co-Authored-By: LeSeulArtichaut <leseulartichaut@gmail.com>
@XAMPPRocky
Update RELEASES.md
1d2fbbe
@XAMPPRocky@LeSeulArtichaut
Update RELEASES.md
53790bb
Co-Authored-By: LeSeulArtichaut <leseulartichaut@gmail.com>
Mark-Simulacrum
Mark-Simulacrum reviewed Mar 24, 2020
View reviewed changes
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
Comment threadRELEASES.md Outdated
@ehuss

ehuss commented Mar 24, 2020

Copy link
Copy Markdown
Contributor

I was wondering if it would be OK to include the addition of config-profiles in Cargo? It's a fairly straightforward change where the [profile] tables can now be specified in .cargo/config files. This also means that profiles can be modified with environment variables like CARGO_PROFILE_RELEASE_LTO=true. Stabilization PR and documentation.

Also, there's another, smaller change: The environment variable CARGO_BIN_EXE_<name> is set when compiling integration tests so that they can find the path to a package's executables. I'd like to encourage people to use that instead of contortions such as examining env::current_exe(). PR and docs.

XAMPPRockyand others added 3 commits March 24, 2020 18:23
@XAMPPRocky@Mark-Simulacrum
Update RELEASES.md
5baef96
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
@XAMPPRocky@Mark-Simulacrum
Update RELEASES.md
f24cc7b
Co-Authored-By: Mark Rousskov <mark.simulacrum@gmail.com>
@XAMPPRocky
Update RELEASES.md
f4e17cc
@XAMPPRocky

XAMPPRocky commented Mar 24, 2020

Copy link
Copy Markdown
ContributorAuthor

@ehuss Added those items.

Centril
Centril reviewed Mar 24, 2020
View reviewed changes
Comment threadRELEASES.md Outdated
@XAMPPRocky@Centril
Update RELEASES.md
ce3193f
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
@Mark-Simulacrum

Mark-Simulacrum commented Mar 26, 2020

Copy link
Copy Markdown
Member

Please add a compatibility note for #69548 as it is a breaking change for a few crates.

@Mark-Simulacrum

Mark-Simulacrum commented Mar 26, 2020

Copy link
Copy Markdown
Member

Also, it sounds like #69340 should also be added to the compatibility notes -- see #70443 and #70444 for some sample error logs.

tspiteri
tspiteri reviewed Mar 27, 2020
View reviewed changes
Comment threadRELEASES.md Outdated
Mark-Simulacrum
Mark-Simulacrum reviewed Apr 11, 2020
View reviewed changes

@Mark-SimulacrumMark-Simulacrum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a few nits left but overall looks good. Thanks!

Comment threadRELEASES.md Outdated
@XAMPPRocky

XAMPPRocky commented Apr 11, 2020

Copy link
Copy Markdown
ContributorAuthor

Should be ready to merge now.

@Mark-Simulacrum

Mark-Simulacrum commented Apr 15, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Apr 15, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit dda3445 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2020
@Mark-SimulacrumMark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 15, 2020
@Mark-SimulacrumMark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 15, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 15, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2020
@bors
Auto merge ofrust-lang#71180- Dylan-DPC:rollup-pscpg6q, r=Dylan-DPC
ce1ab35
Rollup of 6 pull requests
Successful merges:
- rust-lang#69903 (Do not ICE in the face of invalid enum discriminant)
- rust-lang#70354 (Update RELEASES.md for 1.43.0)
- rust-lang#70774 (End cleanup on rustdoc-js tools)
- rust-lang#70990 (Improve rustdoc source code a bit)
- rust-lang#71145 (Add illumos triple)
- rust-lang#71166 (Clean up E0518 explanation)
Failed merges:
r? @ghost
@bors
bors merged commit 3c6e193 into rust-lang:masterApr 16, 2020
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Apr 17, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2020
@bors
Auto merge ofrust-lang#71258- Mark-Simulacrum:beta-next, r=Mark-Sim…
062dea0
…ulacrum
[beta] backports
This includes:
* Do not reuse post LTO products when exports change rust-lang#71131
* macro_rules: `NtLifetime` cannot start with an identifier rust-lang#70768
* Update RELEASES.md for 1.43.0 rust-lang#70354
r? @ghost
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 20, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-SimulacrumMark-SimulacrumMark-Simulacrum left review comments
+5 more reviewers
@CentrilCentrilCentril left review comments
@kellerkindtkellerkindtkellerkindt left review comments
@BatmanAoDBatmanAoDBatmanAoD left review comments
@tspiteritspiteritspiteri left review comments
@LeSeulArtichautLeSeulArtichautLeSeulArtichaut left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@XAMPPRocky@ehuss@Mark-Simulacrum@bors@Centril@kellerkindt@BatmanAoD@tspiteri@LeSeulArtichaut@rust-highfive