Skip to content

Mark hotplug_codegen_backend as ignore-stage1 - #70368

Merged
bors merged 1 commit into
rust-lang:masterfrom
bjorn3:patch-2
Mar 24, 2020
Merged

Mark hotplug_codegen_backend as ignore-stage1#70368
bors merged 1 commit into
rust-lang:masterfrom
bjorn3:patch-2

Conversation

@bjorn3

Copy link
Copy Markdown
Member

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2020
@eddyb

Copy link
Copy Markdown
Contributor

Have you confirmed that works, btw? I wasn't aware of compiletest parsing # comments in Makefiles.

@bjorn3

Copy link
Copy Markdown
MemberAuthor

I haven't, but several other Makefile's have the same annotation: https://github.com/rust-lang/rust/search?q=%23+ignore-stage1&unscoped_q=%23+ignore-stage1

@jonas-schievink

Copy link
Copy Markdown
Contributor

I can confirm that this works

@jonas-schievink

Copy link
Copy Markdown
Contributor

Also works fine in stage2, so:

@bors r+ rollup

@bors

bors commented Mar 24, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 33cd9a2 has been approved by jonas-schievink

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2020
@CentrilCentril mentioned this pull request Mar 24, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 24, 2020
Rollup of 8 pull requests
Successful merges:
- rust-lang#70023 (clean up E0436 explanation)
- rust-lang#70234 (#[track_caller] on core::ops::{Index, IndexMut}.)
- rust-lang#70241 (Miri: move ModifiedStatic to ConstEval errors)
- rust-lang#70342 (IoSlice/IoSliceMut should be Send and Sync)
- rust-lang#70350 (Request "-Z unstable-options" for unstable options)
- rust-lang#70355 (Clean up E0454)
- rust-lang#70359 (must_use on split_off)
- rust-lang#70368 (Mark hotplug_codegen_backend as ignore-stage1)
Failed merges:
r? @ghost
@bors
bors merged commit bf1ad22 into rust-lang:masterMar 24, 2020
@bjorn3
bjorn3 deleted the patch-2 branch March 25, 2020 11:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@bjorn3@rust-highfive@eddyb@jonas-schievink@bors@nikomatsakis