Skip to content

Make x.py compatible with python 3.8. - #70392

Merged
bors merged 1 commit into
rust-lang:masterfrom
brain0:fixxpy
Mar 26, 2020
Merged

Make x.py compatible with python 3.8.#70392
bors merged 1 commit into
rust-lang:masterfrom
brain0:fixxpy

Conversation

@brain0

@brain0brain0 commented Mar 25, 2020

Copy link
Copy Markdown

Python 3.8 removes the time.clock() function, use time.perf_counter() instead.

Thomas Bächler
Make x.py compatible with python 3.8.
a9484d4
Python 3.8 removes the time.clock() function, use time.perf_counter() instead.
@rust-highfive

rust-highfive commented Mar 25, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 25, 2020
@Mark-Simulacrum

Mark-Simulacrum commented Mar 25, 2020

Copy link
Copy Markdown
Member

Can you confirm this works with Python 2 as well? (Seems so, based on the PR builders).

If so, r=me

@brain0

brain0 commented Mar 25, 2020

Copy link
Copy Markdown
Author

Sorry, I cannot test this with python2. On my system, lldb -P points to the python3 package directory, so I cannot use python2 for x.py test. I would guess that it's fine, and the PR builders work, so we should be okay.

@Mark-Simulacrum

Mark-Simulacrum commented Mar 25, 2020

Copy link
Copy Markdown
Member

@bors r+

Okay, I've done some more checking and it seems like this is correct. Thanks.

@bors

bors commented Mar 25, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit a9484d4 has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Mar 25, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2020
@bors
Auto merge ofrust-lang#70412- Dylan-DPC:rollup-yuq2mfy, r=Dylan-DPC
e4519e2
Rollup of 5 pull requests
Successful merges:
- rust-lang#69700 (Rename LayoutDetails to just Layout.)
- rust-lang#70392 (Make x.py compatible with python 3.8.)
- rust-lang#70406 (Clean up E0458 explanation)
- rust-lang#70407 (Avoid tagging as I-nominated on toolstate breakage)
- rust-lang#70409 (gitignore: allow target to be a symlink)
Failed merges:
- rust-lang#70375 (avoid catching InterpError)
r? @ghost
@bors
bors merged commit 0fa57e4 into rust-lang:masterMar 26, 2020
@brain0
brain0 deleted the fixxpy branch April 8, 2020 12:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brain0@rust-highfive@Mark-Simulacrum@bors