Uh oh!
There was an error while loading. Please reload this page.
Create output dir in rustdoc markdown render - #70448
Merged
Merged
Conversation
Dylan-DPC-zz
commented
Mar 26, 2020
GuillaumeGomez
commented
Mar 28, 2020
Member
No, you did great. There isn't really a rule about them, which isn't great. Thanks for this PR! @bors: r+ rollup |
bors
commented
Mar 28, 2020
Collaborator
📌 Commit 6a744ea has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 28, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#70418 (Add long error explanation for E0703) - rust-lang#70448 (Create output dir in rustdoc markdown render) - rust-lang#70486 (Shrink Unicode tables (even more)) - rust-lang#70493 (Fix rustdoc.css CSS tab-size property) - rust-lang#70495 (Replace last mention of IRC with Discord) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustdoccommand on a standalone markdown document fails because the output directory (which default todoc/) is not created, even when specified with the--outputargument.This PR adds the creation of the output directory before the file creation to avoid an unexpected error which is unclear.
I am not sure about the returned error code. I did not find a table explaining them. So I simply put the same error code that is returned when
File::createfails because they are both related to file-system errors.Resolve#70431