Skip to content

Ensure there are versions of test code for aarch64 windows - #70600

Merged
bors merged 1 commit into
rust-lang:masterfrom
danielframpton:aarch64-windows-tests
Mar 31, 2020
Merged

Ensure there are versions of test code for aarch64 windows#70600
bors merged 1 commit into
rust-lang:masterfrom
danielframpton:aarch64-windows-tests

Conversation

@danielframpton

@danielframptondanielframpton commented Mar 31, 2020

Copy link
Copy Markdown
Contributor

Remove the cfg flags that were preventing some tests from running on aarch64-pc-windows-msvc.

All the existing target_os = windows targets had the same align() and size() values, so this change just removes the target_arch flags.

r? @alexcrichton

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2020
@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Mar 31, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit d195620 has been approved by alexcrichton

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2020
Rollup of 7 pull requests
Successful merges:
- rust-lang#69425 (add fn make_contiguous to VecDeque)
- rust-lang#69458 (improve folder name for persistent doc tests)
- rust-lang#70268 (Document ThreadSanitizer in unstable-book)
- rust-lang#70600 (Ensure there are versions of test code for aarch64 windows)
- rust-lang#70606 (Clean up E0466 explanation)
- rust-lang#70614 (remove unnecessary relocation check in const_prop)
- rust-lang#70623 (Fix broken link in README)
Failed merges:
r? @ghost
@bors
bors merged commit b954607 into rust-lang:masterMar 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@danielframpton@rust-highfive@alexcrichton@bors@nikomatsakis