Skip to content

rustc_target::abi: rename FieldPlacement to FieldsShape. - #70616

Merged
bors merged 1 commit into
rust-lang:masterfrom
anyska:fieldplacement-rename
Apr 1, 2020
Merged

rustc_target::abi: rename FieldPlacement to FieldsShape.#70616
bors merged 1 commit into
rust-lang:masterfrom
anyska:fieldplacement-rename

Conversation

@anyska

Copy link
Copy Markdown
Contributor

Originally suggested by @eddyb.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2020
@eddyb

Copy link
Copy Markdown
Contributor

r? @oli-obk cc @RalfJung

@RalfJung

RalfJung commented Mar 31, 2020

Copy link
Copy Markdown
Member

I was never bothered by FieldPlacement. Why is FieldsShape better? It is shorter, granted, but the sS is slightly awkward to read and type.

But it's also not worse, so whatever.^^ No strong opinion here.

@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f259470 has been approved by oli-obk

@bors

bors commented Apr 1, 2020

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 1, 2020
…-obk
rustc_target::abi: rename FieldPlacement to FieldsShape.
Originally suggested by @eddyb.
@CentrilCentril mentioned this pull request Apr 1, 2020
Centril added a commit to Centril/rust that referenced this pull request Apr 1, 2020
…-obk
rustc_target::abi: rename FieldPlacement to FieldsShape.
Originally suggested by @eddyb.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 1, 2020
Rollup of 6 pull requests
Successful merges:
- rust-lang#70535 (Track the finalizing node in the specialization graph)
- rust-lang#70590 (Miri: make backtrace function names and spans match up)
- rust-lang#70616 (rustc_target::abi: rename FieldPlacement to FieldsShape.)
- rust-lang#70626 (cargotest: remove webrender)
- rust-lang#70649 (clean up E0468 explanation)
- rust-lang#70662 (compiletest: don't use `std::io::stdout()`, as it bypasses `set_print`.)
Failed merges:
r? @ghost
@bors
bors merged commit 1b40067 into rust-lang:masterApr 1, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@anyska@rust-highfive@eddyb@RalfJung@oli-obk@bors@petrochenkov