Uh oh!
There was an error while loading. Please reload this page.
Have the per-query caches store the results on arenas - #70674
Conversation
rust-highfive
commented
Apr 1, 2020
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Apr 1, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
rust-highfive
commented
Apr 2, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bors
commented
Apr 2, 2020
☔ The latest upstream changes (presumably #70692) made this pull request unmergeable. Please resolve the merge conflicts. |
rust-highfive
commented
Apr 3, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
matthewjasper
commented
Apr 4, 2020
@bors try @rust-timer queue |
rust-timer
commented
Apr 4, 2020
Awaiting bors try build completion |
bors
commented
Apr 4, 2020
⌛ Trying commit c9f013d922cee0d0fefa70bac5de4d8427ad7340 with merge 5645cd25e3c73522f0b1ab615facc32c8537f062... |
bors
commented
Apr 4, 2020
☀️ Try build successful - checks-azure |
rust-timer
commented
Apr 4, 2020
Queued 5645cd25e3c73522f0b1ab615facc32c8537f062 with parent 1b521f5, future comparison URL. |
matthewjasper
commented
Apr 5, 2020
This appears to be a slight perf regression. |
cjgillot
commented
Apr 5, 2020
Indeed, and I have no idea why. |
Dylan-DPC-zz
commented
Apr 14, 2020
@cjgillot any updates on this? |
bors
commented
Apr 23, 2020
☔ The latest upstream changes (presumably #71044) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
commented
Apr 24, 2020
☔ The latest upstream changes (presumably #71215) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
commented
Apr 28, 2020
☔ The latest upstream changes (presumably #71292) made this pull request unmergeable. Please resolve the merge conflicts. |
cjgillot
commented
Apr 28, 2020
Rebased. Can I get another perf run? |
matthewjasper
commented
Apr 28, 2020
@bors try @rust-timer queue |
rust-timer
commented
Apr 28, 2020
Awaiting bors try build completion |
bors
commented
Apr 28, 2020
⌛ Trying commit d7d2185 with merge 040acbcab104f84b25bd6be13b98182374fff2ab... |
bors
commented
Apr 28, 2020
☀️ Try build successful - checks-azure |
rust-timer
commented
Apr 28, 2020
Queued 040acbcab104f84b25bd6be13b98182374fff2ab with parent fb5615a, future comparison URL. |
rust-timer
commented
Apr 28, 2020
Finished benchmarking try commit 040acbcab104f84b25bd6be13b98182374fff2ab, comparison URL. |
cjgillot
commented
Apr 28, 2020
Perf is neutral. |
matthewjasper
commented
Apr 30, 2020
@bors r+ |
bors
commented
Apr 30, 2020
📌 Commit d7d2185 has been approved by |
bors
commented
May 1, 2020
bors
commented
May 1, 2020
☀️ Test successful - checks-azure |
Remove QueryStorage::store_nocache This method was added in rust-lang#70674 but it doesn't seem to serve any purpose.
Remove QueryStorage::store_nocache This method was added in rust-lang/rust#70674 but it doesn't seem to serve any purpose.
This PR leverages the cache for each query to serve as storage area for the query results.
It introduces a new cache
ArenaCache, which moves the result to an arena,and only stores the reference in the hash map.
This allows to remove a sizeable part of the usage of the global
TyCtxtarena.I only migrated queries that already used arenas before.