Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #70734
Merged
Merged
Conversation
Make sure we check the case where the generic operand comes first, in case any future changes make this ordering matter.
Since rust-lang@2f62265 there has been only one invocation.
Also, fix the goofy reversed names with something clearer.
…RalfJung Extend rust-lang#69020 test to include reversed operand order. Make sure we still emit if a lint if the generic argument comes first. See rust-lang#70566 (comment). r? @RalfJung
Minor cleanup in rustdoc --check-theme Expand and remove try_something macro. Since rust-lang@2f62265 there has been only one invocation. r? @GuillaumeGomez
Avoid `.unwrap()`s on `.span_to_snippet(...)`s First commit fixesrust-lang#70724 and the others fix similar issues found by grepping. r? @estebank
Minor doc improvements on `AllocRef` r? @Amanieu
…ylan-DPC Fix link in task::Wake docs `task::Wake` was introduced in rust-lang#68700. While I was browsing the docs I noticed a link to `sync::Arc` wasn't resolving correctly. This patch fixes that. Thanks! ## Before  ## Proposed 
…=eddyb Minor follow-up after renaming librustc(_middle) Fixesrust-lang#70537 r? @Centril@eddyb
Dylan-DPC-zz
commented
Apr 3, 2020
Author
@bors r+ p=6 rollup=never |
bors
commented
Apr 3, 2020
Collaborator
📌 Commit 04824f3 has been approved by |
bors
commented
Apr 3, 2020
Collaborator
bors
commented
Apr 3, 2020
Collaborator
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
.unwrap()s on.span_to_snippet(...)s #70725 (Avoid.unwrap()s on.span_to_snippet(...)s)AllocRef#70728 (Minor doc improvements onAllocRef)Failed merges:
r? @ghost