Skip to content

docs: make the description of Result::map_or more clear - #70760

Merged
bors merged 1 commit into
rust-lang:masterfrom
PonasKovas:docs
Apr 5, 2020
Merged

docs: make the description of Result::map_or more clear#70760
bors merged 1 commit into
rust-lang:masterfrom
PonasKovas:docs

Conversation

@PonasKovas

@PonasKovasPonasKovas commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

The documentation of Result::map_or is very unclear and confusing, probably because it was copied straight from Option::map_or and someone forgot to adapt it for Result.

@rust-highfive

rust-highfive commented Apr 4, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2020
@Dylan-DPC-zz

Dylan-DPC-zz commented Apr 5, 2020

Copy link
Copy Markdown

@bors r+ rollup

@bors

bors commented Apr 5, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit b4f416d has been approved by Dylan-DPC

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 5, 2020
Merged
TimDiekmann
TimDiekmann reviewed Apr 5, 2020
View reviewed changes
Comment threadsrc/libcore/result.rs
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2020
@bors
Auto merge ofrust-lang#70807- Dylan-DPC:rollup-qd1kgl2, r=Dylan-DPC
e6cef04
Rollup of 5 pull requests
Successful merges:
- rust-lang#70558 (Fix some aliasing issues in Vec)
- rust-lang#70760 (docs: make the description of Result::map_or more clear)
- rust-lang#70769 (Miri: remove an outdated FIXME)
- rust-lang#70776 (clarify comment in RawVec::into_box)
- rust-lang#70806 (fix Miri assignment sanity check)
Failed merges:
r? @ghost
@bors
bors merged commit 6f595e8 into rust-lang:masterApr 5, 2020
@PonasKovas
PonasKovas deleted the docs branch April 5, 2020 16:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@Dylan-DPC-zzDylan-DPC-zzDylan-DPC-zz left review comments
@TimDiekmannTimDiekmannTimDiekmann left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@joshtriplettjoshtriplett

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PonasKovas@rust-highfive@Dylan-DPC-zz@bors@TimDiekmann@joshtriplett