Skip to content

Consider methods on fundamental impl when method is not found on numeric type - #70784

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:suggest-type-fundamental-method
Apr 10, 2020
Merged

Consider methods on fundamental impl when method is not found on numeric type#70784
bors merged 1 commit into
rust-lang:masterfrom
estebank:suggest-type-fundamental-method

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Fix#47759.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 4, 2020
@rust-highfive

This comment has been minimized.

@estebank
estebankforce-pushed the suggest-type-fundamental-method branch from d6dd871 to 2233f13CompareApril 5, 2020 22:38

@matthewjaspermatthewjasper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with terminology changed

Comment threadsrc/librustc_typeck/check/method/suggest.rs Outdated
@estebank
estebankforce-pushed the suggest-type-fundamental-method branch from 2233f13 to a2a65a8CompareApril 10, 2020 00:46
@estebank

Copy link
Copy Markdown
ContributorAuthor

@bors r=matthewjasper

@bors

bors commented Apr 10, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit a2a65a8 has been approved by matthewjasper

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2020
@CentrilCentril mentioned this pull request Apr 10, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 10, 2020
Rollup of 8 pull requests
Successful merges:
- rust-lang#70784 (Consider methods on fundamental `impl` when method is not found on numeric type)
- rust-lang#70843 (Remove the Ord bound that was plaguing drain_filter)
- rust-lang#70913 (Replace "rc"/"arc" lang items with Rc/Arc diagnostic items.)
- rust-lang#70932 (De-abuse TyKind::Error in pattern type checking)
- rust-lang#70952 (Clean up E0511 explanation)
- rust-lang#70964 (rustc_session CLI lint parsing: mark a temporary hack as such)
- rust-lang#70969 (Fix JSON file_name documentation for macros.)
- rust-lang#70975 (Fix internal doc comment nits.)
Failed merges:
r? @ghost
@bors
bors merged commit dff5a11 into rust-lang:masterApr 10, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mediocre error message for f32/f64 ambiguity

4 participants

@estebank@rust-highfive@bors@matthewjasper