Skip to content

Use assoc int submodules - #70854

Merged
bors merged 3 commits into
rust-lang:masterfrom
faern:use-assoc-int-submodules
Apr 7, 2020
Merged

Use assoc int submodules#70854
bors merged 3 commits into
rust-lang:masterfrom
faern:use-assoc-int-submodules

Conversation

@faern

@faernfaern commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

Bumping some submodules to the commits their masters currently point at. The main point of this is to get the associated integer/float constant documentation updates that were recently merged to them:

But for some, a few more changes slipped by that happened to be in the master branch of these submodules.

r? @dtolnay

@rust-highfive

Copy link
Copy Markdown
Contributor

⚠️Warning⚠️

  • These commits modify submodules.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2020
@dtolnay

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Apr 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 01b3293 has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2020
@Centril

Copy link
Copy Markdown
Contributor

But for some, a few more changes slipped by that happened to be in the master branch of these submodules.

Please include a summary of those changes in the future. Thanks.

Centril added a commit to Centril/rust that referenced this pull request Apr 7, 2020
…tolnay
Use assoc int submodules
Bumping some submodules to the commits their masters currently point at. The main point of this is to get the associated integer/float constant documentation updates that were recently merged to them:
* rust-lang/nomicon#207
* rust-lang/rust-by-example#1327
* rust-lang/stdarch#848
But for some, a few more changes slipped by that happened to be in the master branch of these submodules.
r? @dtolnay
@CentrilCentril mentioned this pull request Apr 7, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2020
…ievink
Rollup of 5 pull requests
Successful merges:
- rust-lang#70201 (Small tweaks in ToOwned::clone_into)
- rust-lang#70762 (Miri leak check: memory reachable through globals is not leaked)
- rust-lang#70846 (Keep codegen units unmerged when building compiler builtins)
- rust-lang#70854 (Use assoc int submodules)
- rust-lang#70857 (Don't import integer and float modules, use assoc consts 2)
Failed merges:
r? @ghost
@bors
bors merged commit 78c64d0 into rust-lang:masterApr 7, 2020
@faern
faern deleted the use-assoc-int-submodules branch April 16, 2020 21:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@faern@rust-highfive@dtolnay@bors@Centril