Uh oh!
There was an error while loading. Please reload this page.
Update rustc-dev-guide - #70873
Conversation
rust-highfive
commented
Apr 7, 2020
|
rust-highfive
commented
Apr 7, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Hm, overall looks good but GitHub returns the 429 status code. IIRC I've seen this failure on rustc-dev-guide side also. Can we avoid this to tweak link checker config or something? |
mark-i-m
commented
Apr 7, 2020
@JohnTitor I think this code could be updated to filter out 429's: rust/src/tools/rustbook/src/main.rs Lines 106 to 128 in 42abbd8 |
JohnTitor
commented
Apr 7, 2020
That's a good idea! r=me once it's updated. |
mark-i-m
commented
Apr 8, 2020
It looks like there are some actually broken links atm, so let me fix those and update this pr too. |
mark-i-m
commented
Apr 8, 2020
rust-highfive
commented
Apr 8, 2020
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
mark-i-m
commented
Apr 8, 2020
Should hopefully pass now. Let's wait for CI. |
mark-i-m
commented
Apr 9, 2020
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author @JohnTitor ready :) |
JohnTitor
commented
Apr 9, 2020
Thanks! @bors r+ |
bors
commented
Apr 9, 2020
📌 Commit 0d9bf52 has been approved by |
Update rustc-dev-guide This should finally fix toolstate r? @JohnTitor
Centril
commented
Apr 9, 2020
Failed in #70955 (comment), @bors r- |
mark-i-m
commented
Apr 10, 2020
This is still passing for me locally? Perhaps it was a spurious failure we didn't expect? I looked through the log, but it's long and I guess I missed whatever error caused the failure. |
Mark-Simulacrum
commented
Apr 10, 2020
Looks spurious to me, though I feel like maybe we shouldn't be running linkcheck quite like this in CI... I have no better suggestions necessarily though, just feeling a bit like we'll likely hit errors like this frequently? @bors r=JohnTitor |
bors
commented
Apr 10, 2020
📌 Commit 0d9bf52 has been approved by |
JohnTitor
commented
Apr 10, 2020
At a glance, the real error is only and it's spurious. The current link check emits all the errors including filtered ones when there's a real error, it isn't ideal.. |
mark-i-m
commented
Apr 11, 2020
@JohnTitor It's definitely worth re-evaluating whether it's really doing its job here... |
bors
commented
Apr 12, 2020
JohnTitor
commented
Apr 12, 2020
@mark-i-m You point to emitting the errors, right? Hm, fair enough. Anyway we should deal with the GH links' failures properly if it continues. |
bors
commented
Apr 12, 2020
☀️ Test successful - checks-azure |
rust-highfive
commented
Apr 12, 2020
📣 Toolstate changed by #70873! Tested on commit 4d1fbac. 🎉 rustc-dev-guide on linux: test-fail → test-pass (cc @JohnTitor@amanjeev@spastorino@mark-i-m). |
Tested on commit rust-lang/rust@4d1fbac. Direct link to PR: <rust-lang/rust#70873> 🎉 rustc-dev-guide on linux: test-fail → test-pass (cc @JohnTitor@amanjeev@spastorino@mark-i-m).
This should finally fix toolstate
r? @JohnTitor