Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #70966
Closed
Dylan-DPC-zz wants to merge 19 commits into
Closed
Conversation
Before, it ignored the first argument and marked all variables without `Storage*` annotations as dead.
… r=tmandry Add utility to find locals that don't use `StorageLive` annotations and use it for `MaybeStorageLive` Addresses rust-lang#70004 (comment) (cc @RalfJung). The only dataflow analysis that is incorrect in this case is `MaybeStorageLive`. `transform/generator.rs` implemented custom handling for this class of locals, but other consumers of this analysis (there's one in [clippy](https://github.com/rust-lang/rust-clippy/blob/513b46793e98ce5b412d388a91f6371d6a9b290b/clippy_lints/src/redundant_clone.rs#L402)) would be incorrect. r? @tmandry
rustc_target::abi: add Primitive variant to FieldsShape. Originally suggested by @eddyb.
…tthewjasper Replace "rc"/"arc" lang items with Rc/Arc diagnostic items. `Rc`/`Arc` should have no special semantics, so it seems appropriate for them to not be lang items. r? @matthewjasper
De-abuse TyKind::Error in pattern type checking r? @eddyb cc rust-lang#70866 In particular, I would appreciate extra scrutiny over the soundness of these changes. Also, this will go a bit slowly because I'm going to use my other PR (rust-lang#70551) to check if I missed anything.
…an-DPC Clean up E0511 explanation r? @Dylan-DPC
…ochenkov rustc_session CLI lint parsing: mark a temporary hack as such This code was added in rust-lang#70918, but it should not be necessary any more once `forbid` works as expected for in-code attributes. Cc @tobithiel@davidtwco
Dylan-DPC-zz
commented
Apr 9, 2020
Author
@bors r+ rollup=never p=6 |
bors
commented
Apr 9, 2020
Collaborator
📌 Commit f124d7f has been approved by |
bors
commented
Apr 10, 2020
Collaborator
⌛ Testing commit f124d7f with merge c6b3c857bb716a3a09a80b15cda3eb60368dc906... |
bors
commented
Apr 10, 2020
Collaborator
💔 Test failed - checks-azure |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
StorageLiveannotations and use it forMaybeStorageLive#70447 (Add utility to find locals that don't useStorageLiveannotations and use it forMaybeStorageLive)Failed merges:
r? @ghost